Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42443 )
Change subject: mb/google/hatch: Reduce PchPmSlpAMinAssert to 98ms ......................................................................
mb/google/hatch: Reduce PchPmSlpAMinAssert to 98ms
Reduce PchPmSlpAMinAssert (SLP_A_MIN_ASST_WIDTH) to minimum time(98ms) from 2sec as the SLP_A pin is not connected on hatch.
Test=Verified on hatch
Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Change-Id: Iafd0ad8b3ab20cbd2463bf443d2f670fb7be414c --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/42443/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 2d3156a..486ab66 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -142,7 +142,7 @@ register "PchPmSlpS3MinAssert" = "2" # 50ms register "PchPmSlpS4MinAssert" = "1" # 1s register "PchPmSlpSusMinAssert" = "1" # 500ms - register "PchPmSlpAMinAssert" = "3" # 2s + register "PchPmSlpAMinAssert" = "2" # 98ms
# Enable Audio DSP oscillator qualification for S0ix register "cppmvric2_adsposcdis" = "1"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42443 )
Change subject: mb/google/hatch: Reduce PchPmSlpAMinAssert to 98ms ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@7 PS1, Line 7: 98ms 98 ms
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@10 PS1, Line 10: time(98ms) from 2sec as the SLP_A pin is not connected on hatch. Please add a space before the ( and the unit (SI unit is *s*).
https://review.coreboot.org/c/coreboot/+/42443/1//COMMIT_MSG@12 PS1, Line 12: Test=Verified on hatch How is that time verified?
Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42443 )
Change subject: mb/google/hatch: Reduce PchPmSlpAMinAssert to 98ms ......................................................................
Abandoned
Existing code set PchPmSlpAMinAssert to 98ms. The patch is not required. Only correcting comment is sufficient.
-
Paul Menzel (Code Review) -
Sridhar Siricilla (Code Review)