Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29579 )
Change subject: src/arch/x86/acpi.c: Update ACPI table revisions
......................................................................
Patch Set 2: Code-Review-1
You need to update all those table prototypes, which might increase their size due to new table entries and implement all the new functionality. Just incrementing the revision doesn't improve anything, it might even confuse the operating system.
--
To view, visit
https://review.coreboot.org/29579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22020bd156536ee8f23a267d7c7b2d7af6c7cfeb
Gerrit-Change-Number: 29579
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 11 Nov 2018 15:59:20 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes