Change in coreboot[master]: soc/intel/tigerlake: Add IPU in ACPI

[Wonkyu Kim (Code Review)]

Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

soc/intel/tigerlake: Add IPU in ACPI

BUG=none
BRANCH=none
TEST=Build and boot tigerlake rvp board

Signed-off-by: Wonkyu Kim 
Change-Id: I8c1ca9c053f0c8ef8d7c027c317c7af74d5f0f8c
---
A src/soc/intel/tigerlake/acpi/ipu.asl
1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38469/1

diff --git a/src/soc/intel/tigerlake/acpi/ipu.asl b/src/soc/intel/tigerlake/acpi/ipu.asl
new file mode 100644
index 0000000..1913003
--- /dev/null
+++ b/src/soc/intel/tigerlake/acpi/ipu.asl
@@ -0,0 +1,24 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2020 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+Scope (_SB.PCI0)
+{
+	Device (IPU0)
+	{
+		Name (_ADR, 0x00050000)
+		Name (_DDN, "Camera and Imaging Subsystem")
+	}
+}
+

[Wonkyu Kim (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38469

to look at the new patch set (#2).

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

soc/intel/tigerlake: Add IPU in ACPI

BUG=none
BRANCH=none
TEST=Build and boot tigerlake rvp board

Signed-off-by: Wonkyu Kim 
Change-Id: I8c1ca9c053f0c8ef8d7c027c317c7af74d5f0f8c
---
A src/soc/intel/tigerlake/acpi/ipu.asl
1 file changed, 23 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38469/2

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 2: Code-Review+1

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38469/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38469/3//COMMIT_MSG@9 
PS3, Line 9: BUG=none
           : BRANCH=none
           : TEST=Build and boot tigerlake rvp board
please add some lines about what changes are made in code.

[Wonkyu Kim (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38469

to look at the new patch set (#4).

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

soc/intel/tigerlake: Add IPU in ACPI

Add IPU ACPI object for Camera ACPI.

BUG=none
BRANCH=none
TEST=Build and boot tigerlake rvp board

Signed-off-by: Wonkyu Kim 
Change-Id: I8c1ca9c053f0c8ef8d7c027c317c7af74d5f0f8c
---
A src/soc/intel/tigerlake/acpi/ipu.asl
1 file changed, 23 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/38469/4

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38469/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38469/3//COMMIT_MSG@9 
PS3, Line 9: BUG=none
           : BRANCH=none
           : TEST=Build and boot tigerlake rvp board
> please add some lines about what changes are made in code.

Ack

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 5: Code-Review+2

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 5: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

soc/intel/tigerlake: Add IPU in ACPI

Add IPU ACPI object for Camera ACPI.

BUG=none
BRANCH=none
TEST=Build and boot tigerlake rvp board

Signed-off-by: Wonkyu Kim 
Change-Id: I8c1ca9c053f0c8ef8d7c027c317c7af74d5f0f8c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38469
Tested-by: build bot (Jenkins) 
Reviewed-by: Pratikkumar V Prajapati 
Reviewed-by: Nick Vaccaro 
---
A src/soc/intel/tigerlake/acpi/ipu.asl
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Pratikkumar V Prajapati: Looks good to me, approved
  Nick Vaccaro: Looks good to me, approved
  Wonkyu Kim: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/tigerlake/acpi/ipu.asl b/src/soc/intel/tigerlake/acpi/ipu.asl
new file mode 100644
index 0000000..ed964a4
--- /dev/null
+++ b/src/soc/intel/tigerlake/acpi/ipu.asl
@@ -0,0 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2020 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+Scope (_SB.PCI0)
+{
+	Device (IPU0)
+	{
+		Name (_ADR, 0x00050000)
+		Name (_DDN, "Camera and Imaging Subsystem")
+	}
+}

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38469 )

Change subject: soc/intel/tigerlake: Add IPU in ACPI
......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/275
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/274
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/273

Please note: This test is under development and might not be accurate at all!