Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29065 )
Change subject: cpu/amd: [WIP] Use common AMD's MSR ......................................................................
Patch Set 7:
(12 comments)
https://review.coreboot.org/#/c/29065/6/src/cpu/amd/agesa/family15tn/model_1... File src/cpu/amd/agesa/family15tn/model_15_init.c:
https://review.coreboot.org/#/c/29065/6/src/cpu/amd/agesa/family15tn/model_1... PS6, Line 29: #include <cpu/amd/amdfam15.h> Remove, no longer needed.
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/agesa/family16kb/model_1... File src/cpu/amd/agesa/family16kb/model_16_init.c:
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/agesa/family16kb/model_1... PS7, Line 28: nclude <cpu/amd/amdfam16.h> remove
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/agesa/family16kb/model_1... PS7, Line 75: MCG_CAP IA32_MCG_CAP
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/family_10h-family_15h/mo... File src/cpu/amd/family_10h-family_15h/model_10xxx_init.c:
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/family_10h-family_15h/mo... PS7, Line 19: #include <cpu/amd/msr.h> : Does this belongs to this patch? All you did was moving the includes around.
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00630F01/model_15_ini... File src/cpu/amd/pi/00630F01/model_15_init.c:
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00630F01/model_15_ini... PS7, Line 30: #include <cpu/amd/amdfam15.h> Remove
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00660F01/model_15_ini... File src/cpu/amd/pi/00660F01/model_15_init.c:
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00660F01/model_15_ini... PS7, Line 29: #include <cpu/amd/amdfam15.h> remove
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00660F01/model_15_ini... PS7, Line 86: MCG_CAP IA32_MCG_CAP
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00730F01/model_16_ini... File src/cpu/amd/pi/00730F01/model_16_init.c:
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00730F01/model_16_ini... PS7, Line 29: include <cpu/amd/amdfam16.h> remove
https://review.coreboot.org/#/c/29065/7/src/cpu/amd/pi/00730F01/model_16_ini... PS7, Line 71: MCG_CAP IA32_MCG_CAP
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/cpu.c File src/soc/amd/stoneyridge/cpu.c:
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/cpu.c@23 PS7, Line 23: #include <cpu/amd/amdfam15.h remove
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/finalize.c File src/soc/amd/stoneyridge/finalize.c:
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/finalize.c@1... PS7, Line 19: #include <cpu/amd/amdfam15.h> remove
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/ramtop.c File src/soc/amd/stoneyridge/ramtop.c:
https://review.coreboot.org/#/c/29065/7/src/soc/amd/stoneyridge/ramtop.c@24 PS7, Line 24: #include <cpu/amd/amdfam15.h> remove