Attention is currently required from: Nico Huber, Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63763 )
Change subject: device/Kconfig: Change ON_DEVICE_ROM_LOAD default ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63763/comment/5621d5ea_fb1ccd75 PS1, Line 9: is not a good : idea in an open source project
Why? I understand the security perspective, and would only mention that. […]
Done
Patchset:
PS1:
Should we add something to configs/ to keep the path build tested? Currently there are Galileo configs enabling it, but they might be gone soon.
Done
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/63763/comment/77f0a56e_a22a19bd PS1, Line 180: If you are concerned about security, you might want to : disable this option, but it might leave your system in a state of : degraded functionality.
This would need to be updated.
Done
https://review.coreboot.org/c/coreboot/+/63763/comment/51d105ed_27f19b21 PS1, Line 180: If you are concerned about security, you might want to : disable this option, but it might leave your system in a state of : degraded functionality.
This would need to be updated.
Done
-
Arthur Heymans (Code Review)