Change in coreboot[master]: drivers/intel/fsp2_0: Add support for MP services2 PPI

[Aamir Bohra (Code Review)]

Attention is currently required from: Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Meera Ravindranath, Andrey Petrov, Patrick Rudolph.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49474 )

Change subject: drivers/intel/fsp2_0: Add support for MP services2 PPI
......................................................................

Patch Set 9:

(3 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/49474/comment/b55c2bda_a6c5447d 
PS6, Line 267: 
             : if FSP_PEIM_TO_PEIM_INTERFACE
             : source "src/drivers/intel/fsp2_0/ppi/Kconfig"
             : endif
             :
> It's redundant, src/Kconfig already has `source "src/drivers/*/*/*/Kconfig`

yeah.

File src/drivers/intel/fsp2_0/include/fsp/ppi/mp_service_ppi.h:

https://review.coreboot.org/c/coreboot/+/49474/comment/4aecfe34_6f24e8c7 
PS6, Line 49: /*
            :  * switches the requested AP to be the BSP
            :  */
            : efi_return_status_t mp_switch_bsp(void);
            : 
            : /*
            :  * enable or disable an AP. This service may only be called from the BSP.
            :  */
            : efi_return_status_t mp_enable_disable_ap(void);
            :
> We could just have a `efi_return_status_t fsp_ppi_unsupported(void) { return FSP_UNSUPPORTED; }` as  […]

wanted to match to :

EDKII_PEI_MP_SERVICES2_PPI            mMpServices2Ppi = {
  EdkiiPeiGetNumberOfProcessors,
  EdkiiPeiGetProcessorInfo,
  EdkiiPeiStartupAllAPs,
  EdkiiPeiStartupThisAP,
  EdkiiPeiSwitchBSP,
  EdkiiPeiEnableDisableAP,
  EdkiiPeiWhoAmI,
  EdkiiPeiStartupAllCPUs
};

As I understand are you suggesting below?

EDKII_PEI_MP_SERVICES2_PPI            mMpServices2Ppi = {
  EdkiiPeiGetNumberOfProcessors,
  EdkiiPeiGetProcessorInfo,
  EdkiiPeiStartupAllAPs,
  EdkiiPeiStartupThisAP,
  fsp_ppi_unsupported,
  fsp_ppi_unsupported,
  EdkiiPeiWhoAmI,
  EdkiiPeiStartupAllCPUs
};

File src/drivers/intel/fsp2_0/ppi/mp_service1.c:

https://review.coreboot.org/c/coreboot/+/49474/comment/4d71611c_15b91d8a 
PS6, Line 12:
> nit: extra lines

Done