Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney.
Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50580 )
Change subject: sc7280: Move to use common clock driver for sc7280
......................................................................
Patch Set 57:
(1 comment)
File src/soc/qualcomm/sc7280/clock.c:
https://review.coreboot.org/c/coreboot/+/50580/comment/f539549a_ec15c8ac
PS54, Line 524: return CB_ERR;
Should an error be printed?
zonda_pll_enable() https://review.coreboot.org/c/coreboot/+/56588/2/src/soc/qualcomm/common/clo...
Already prints the LOCK error, do you still want any other error to be printed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50580
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I590a93cda0d6eccb51b54692b620d43ccacede77
Gerrit-Change-Number: 50580
Gerrit-PatchSet: 57
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 28 Jul 2021 08:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment