Change in coreboot[master]: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage
Enable the Kconfig flag VBOOT_VBNV_CMOS_BACKUP_TO_FLASH fpr psp_verstage to save the vbnv data to the SPI rom.
BUG=b:161366241 TEST=Boot Morphius, Read rom from SPI and extract the RW_NVRAM region. See that it's getting updated.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I0d4b92fa321a8409468b8d8fc40be0d4b57b664b --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/43487/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 3bdaad2..bec4167 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -497,7 +497,7 @@
config VBOOT select VBOOT_VBNV_CMOS - select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH if ! VBOOT_STARTS_BEFORE_BOOTBLOCK + select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH
config VBOOT_STARTS_BEFORE_BOOTBLOCK def_bool n
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 1: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43487/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43487/1//COMMIT_MSG@9 PS1, Line 9: fpr for
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43487/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43487/1//COMMIT_MSG@9 PS1, Line 9: fpr
for
Done
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Rob Barnes, Eric Peers, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43487
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage
Enable the Kconfig flag VBOOT_VBNV_CMOS_BACKUP_TO_FLASH for psp_verstage to save the vbnv data to the SPI rom.
BUG=b:161366241 TEST=Boot Morphius, Read rom from SPI and extract the RW_NVRAM region. See that it's getting updated.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I0d4b92fa321a8409468b8d8fc40be0d4b57b664b --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/43487/2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43487 )
Change subject: soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage ......................................................................
soc/amd/picasso: Enable VBNV_BACKUP_TO_FLASH for psp_verstage
Enable the Kconfig flag VBOOT_VBNV_CMOS_BACKUP_TO_FLASH for psp_verstage to save the vbnv data to the SPI rom.
BUG=b:161366241 TEST=Boot Morphius, Read rom from SPI and extract the RW_NVRAM region. See that it's getting updated.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I0d4b92fa321a8409468b8d8fc40be0d4b57b664b Reviewed-on: https://review.coreboot.org/c/coreboot/+/43487 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index aaabf43..526900a 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -497,7 +497,7 @@
config VBOOT select VBOOT_VBNV_CMOS - select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH if ! VBOOT_STARTS_BEFORE_BOOTBLOCK + select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH
config VBOOT_STARTS_BEFORE_BOOTBLOCK def_bool n
-
Aaron Durbin (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Raul Rangel (Code Review)
-
Rob Barnes (Code Review)