Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55397 )
Change subject: cbtable: Store loglevel with consoles ......................................................................
Patch Set 7:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/55397/comment/3f13bc34_4e44d0be PS7, Line 120: console->loglevel = get_console_loglevel(); I think this is the wrong tag, or at least this alone won't help our Chrome OS case. For some reason there are two "console" tags in the coreboot table, this one (which seems to only be used for USB EHCI console?), and lb_serial which is what depthcharge and Arm TF use to determine serial out. It would probably be best to combine those two somehow (e.g. lb_serial also has a `type` field which could be used to implement the functionality from here, and then the serial-specific fields could just be blank for non-serial consoles or something), if anyone even uses this one at all anymore. It's not even parsed by libpayload, so it would have to be one of those custom payloads.
-
Julius Werner (Code Review)