Attention is currently required from: Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph. Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/58094 )
Change subject: soc/intel/{apl,jsl,adl,tgl}: Remove smihandler_soc_disable_busmaster ......................................................................
soc/intel/{apl,jsl,adl,tgl}: Remove smihandler_soc_disable_busmaster
Using default smihandler_soc_disable_busmaster function and remove duplicated code
TEST=power button shutdown ok before and after depthcharge on brya
Change-Id: Iec86bb8cac20c31e4283f7da3467fe09788f8044 Signed-off-by: Kane Chen kane.chen@intel.corp-partner.google.com --- M src/soc/intel/alderlake/smihandler.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/jasperlake/smihandler.c M src/soc/intel/tigerlake/smihandler.c 4 files changed, 0 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/58094/1
diff --git a/src/soc/intel/alderlake/smihandler.c b/src/soc/intel/alderlake/smihandler.c index 5b53038..a072138 100644 --- a/src/soc/intel/alderlake/smihandler.c +++ b/src/soc/intel/alderlake/smihandler.c @@ -24,14 +24,6 @@ heci_disable(); }
-int smihandler_soc_disable_busmaster(pci_devfn_t dev) -{ - /* Skip disabling PMC bus master to keep IO decode enabled */ - if (dev == PCH_DEV_PMC) - return 0; - return 1; -} - const smi_handler_t southbridge_smi[SMI_STS_BITS] = { [SMI_ON_SLP_EN_STS_BIT] = smihandler_southbridge_sleep, [APM_STS_BIT] = smihandler_southbridge_apmc, diff --git a/src/soc/intel/apollolake/smihandler.c b/src/soc/intel/apollolake/smihandler.c index bcbc819..0d8c9d9 100644 --- a/src/soc/intel/apollolake/smihandler.c +++ b/src/soc/intel/apollolake/smihandler.c @@ -8,13 +8,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h>
-int smihandler_soc_disable_busmaster(pci_devfn_t dev) -{ - if (dev == PCH_DEV_PMC) - return 0; - return 1; -} - const struct smm_save_state_ops *get_smm_save_state_ops(void) { return &em64t100_smm_ops; diff --git a/src/soc/intel/jasperlake/smihandler.c b/src/soc/intel/jasperlake/smihandler.c index 2e38b68..448c053 100644 --- a/src/soc/intel/jasperlake/smihandler.c +++ b/src/soc/intel/jasperlake/smihandler.c @@ -24,14 +24,6 @@ heci_disable(); }
-int smihandler_soc_disable_busmaster(pci_devfn_t dev) -{ - /* Skip disabling PMC bus master to keep IO decode enabled */ - if (dev == PCH_DEV_PMC) - return 0; - return 1; -} - const smi_handler_t southbridge_smi[SMI_STS_BITS] = { [SMI_ON_SLP_EN_STS_BIT] = smihandler_southbridge_sleep, [APM_STS_BIT] = smihandler_southbridge_apmc, diff --git a/src/soc/intel/tigerlake/smihandler.c b/src/soc/intel/tigerlake/smihandler.c index 6280fb2..67d21f8 100644 --- a/src/soc/intel/tigerlake/smihandler.c +++ b/src/soc/intel/tigerlake/smihandler.c @@ -24,14 +24,6 @@ heci_disable(); }
-int smihandler_soc_disable_busmaster(pci_devfn_t dev) -{ - /* Skip disabling PMC bus master to keep IO decode enabled */ - if (dev == PCH_DEV_PMC) - return 0; - return 1; -} - const smi_handler_t southbridge_smi[SMI_STS_BITS] = { [SMI_ON_SLP_EN_STS_BIT] = smihandler_southbridge_sleep, [APM_STS_BIT] = smihandler_southbridge_apmc,