Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/19468 )
Change subject: intel/common/block/i2c: Add common block for I2C ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/i2c.c File src/soc/intel/common/block/i2c/i2c.c:
Line 148: static const unsigned short pci_device_ids[] = {
too many new lines
Done
https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/i2c_e... File src/soc/intel/common/block/i2c/i2c_early.c:
PS8, Line 66:
space between ) and {
Done
https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/i2c/lpss_... File src/soc/intel/common/block/i2c/lpss_i2c.h:
Line 79: MIN_SS_SCL_LOWTIME = 4700,
same line
Done
Line 84: MIN_FP_SCL_HIGHTIME = 260,
What about success? Same goes for comment above.
Done
https://review.coreboot.org/#/c/19468/8/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/lpss_i2c.h:
PS8, Line 103: uration.
bus?
Done