Hello Subrata Banik, Patrick Rudolph, Matt DeVillier, Paul Menzel, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34483
to review the following change.
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
device: Default to VESA/linear framebuffer for ChromeOS
Building for ChromeOS implies the use of Depthcharge which doesn't support legacy text mode.
Change-Id: I7fd82bfed1e59de2de75419cfaea6f0c19cfdf5e Signed-off-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/34483/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 0539062..e605bc2 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -255,6 +255,7 @@ config FRAMEBUFFER_SET_VESA_MODE prompt "Set framebuffer graphics resolution" bool + default y if CHROMEOS depends on PCI_OPTION_ROM_RUN_YABEL || PCI_OPTION_ROM_RUN_REALMODE select HAVE_VBE_LINEAR_FRAMEBUFFER help @@ -407,6 +408,8 @@
choice prompt "Framebuffer mode" + default VBE_LINEAR_FRAMEBUFFER if HAVE_VBE_LINEAR_FRAMEBUFFER && CHROMEOS + default GENERIC_LINEAR_FRAMEBUFFER if HAVE_LINEAR_FRAMEBUFFER && CHROMEOS default VGA_TEXT_FRAMEBUFFER
config VGA_TEXT_FRAMEBUFFER
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34483 )
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/34483 )
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
device: Default to VESA/linear framebuffer for ChromeOS
Building for ChromeOS implies the use of Depthcharge which doesn't support legacy text mode.
Change-Id: I7fd82bfed1e59de2de75419cfaea6f0c19cfdf5e Signed-off-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/34483/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34483 )
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+2
Thanks, that was fast.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34483 )
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34483 )
Change subject: device: Default to VESA/linear framebuffer for ChromeOS ......................................................................
device: Default to VESA/linear framebuffer for ChromeOS
Building for ChromeOS implies the use of Depthcharge which doesn't support legacy text mode.
Change-Id: I7fd82bfed1e59de2de75419cfaea6f0c19cfdf5e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/34483 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Subrata Banik subrata.banik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index 0539062..e605bc2 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -255,6 +255,7 @@ config FRAMEBUFFER_SET_VESA_MODE prompt "Set framebuffer graphics resolution" bool + default y if CHROMEOS depends on PCI_OPTION_ROM_RUN_YABEL || PCI_OPTION_ROM_RUN_REALMODE select HAVE_VBE_LINEAR_FRAMEBUFFER help @@ -407,6 +408,8 @@
choice prompt "Framebuffer mode" + default VBE_LINEAR_FRAMEBUFFER if HAVE_VBE_LINEAR_FRAMEBUFFER && CHROMEOS + default GENERIC_LINEAR_FRAMEBUFFER if HAVE_LINEAR_FRAMEBUFFER && CHROMEOS default VGA_TEXT_FRAMEBUFFER
config VGA_TEXT_FRAMEBUFFER
-
Nico Huber (Code Review) -
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)