Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded...
PS10, Line 15: const struct gpio_with_delay lte_power_off_gpios[] = {
: {
: GPP_H17, /* WWAN_RST_L => LTE_RESET_R_ODL */
: 10,
: },
: {
: GPP_A10, /* WWAN_EN => LTE_PWR_OFF_ODL */
: 0
: },
: };
:
: for (int i = 0; i < ARRAY_SIZE(lte_power_off_gpios); i++) {
: gpio_output(lte_power_off_gpios[i].gpio, 0);
: mdelay(lte_power_off_gpios[i].delay_msecs);
: }
This can simply be written as: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d5d21ce5267f147b332a4c9b01a29b3b8ccfb8
Gerrit-Change-Number: 44588
Gerrit-PatchSet: 11
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 05 Nov 2020 20:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment