Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR - coreboot-gerrit

19 Apr 2022


      Attention is currently required from: Henry Sun, Teddy Shih, Aseda Aboagye, Simon Yang, Ivan Chen, Karthik Ramasubramanian.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 )
Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/beadrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63652/comment/18d9d491_8177951f 
PS2, Line 139: 			chip drivers/i2c/sx9324
According to src/drivers/i2c/sx9324/sx9324.c, you may need to provide register uid for ACPI name _UID generation.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63652
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888
Gerrit-Change-Number: 63652
Gerrit-PatchSet: 2
Gerrit-Owner: Teddy Shih teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye aaboagye@google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Ivan Chen yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Simon Yang simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Super Ni super.ni@intel.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih teddyshihau@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eddy Lu eddylu@ami.corp-partner.google.com
Gerrit-CC: Jack Cheng jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung raymondchung@ami.corp-partner.google.com
Gerrit-CC: Simon Yang simon1.yang@intel.com
Gerrit-Attention: Henry Sun henrysun@google.com
Gerrit-Attention: Teddy Shih teddyshihau@gmail.com
Gerrit-Attention: Aseda Aboagye aaboagye@google.com
Gerrit-Attention: Simon Yang simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Ivan Chen yulunchen@google.com
Gerrit-Attention: Teddy Shih teddyshih@ami.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Tue, 19 Apr 2022 03:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment