Attention is currently required from: Mario Scheithauer, Werner Zeh, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54911 )
Change subject: mb/siemens/{mc_apl2,...,mc_apl6}: Do early UART pad configuration
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54911/comment/735b0c68_d50a65de
PS3, Line 9: With commit 405f2296892c10a48db50cd66c2eb364cde0806e the UART pad
i consider using short git hashes bad practice, since that massively increases the chance of collisi […]
Note, in the commit message it’s only for reference, and not for security. Linux takes twelve characters, and depending on the amount of commits in coreboot, a shorter number might be acceptable. It’s a compromise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If78726d9b141e4e7580cca3267f49c1a5b95d7fa
Gerrit-Change-Number: 54911
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 29 May 2021 07:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment