Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46882 )
Change subject: soc/intel/common/block/cse: Add functions to support setting DAM state
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46882/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/46882/5/src/soc/intel/common/block/...
PS5, Line 986: -1
ret instead of -1
If DAM is already disabled, then we dont want to return -1. Only when DAM state could not be read, we need to return -1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If42eb150577e9f76318e77ae31eb6f5844a4143d
Gerrit-Change-Number: 46882
Gerrit-PatchSet: 5
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Nov 2020 00:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment