Attention is currently required from: Selma Bensaid, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58993 )
Change subject: soc/intel/common/cse: Add support to get CSME timestamps ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58993/comment/8000b92f_4a9c4d12 PS3, Line 10: while
`during`
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58993/comment/5d3c1204_f8389167 PS3, Line 126:
nit: extra line
Done
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/58993/comment/1eef02df_10776fff PS3, Line 153: /* Early boot performance data */ : /* 0: CSME ROM start execution */ : /* 1: EC Boot Load Done (CSME ROM starts main execution) */ : /* 2: CSME ROM completed execution / CSME RBE started */ : /* 3: CSME got ESE Init Done indication from ESE */ : /* 4: CSME RBE start PMC patch/es loading */ : /* 5: CSME RBE completed PMC patch/es loading */ : /* 6: CSME RBE set "Boot Stall Done" indication to PMC */ : /* 7: CSME start poll for PMC PPS register */ : /* 8: PMC set PPS */ : /* 9: CSME BUP start running */ : /* 10: CSME set "Host Boot Prep Done" indication to PMC */ : /* 11: CSME starts PHYs loading */ : /* 12: CSME completed PHYs loading */ : /* 13: PMC indicated CSME that xxPWRGOOD was asserted */ : /* 14: PMC indicated CSME that SYS_PWROK was asserted */ : /* 15: PMC sent "CPU_BOOT_CONFIG" start message to CSME */ : /* 16: CSME sent "CPU_BOOT_CONFIG" done message to PMC */ : /* 17: PMC indicated CSME that xxPLTRST was de-asserted */ : /* 18: PMC indicated CSME that TCO_S0 was asserted */ : /* 19: PMC sent "Core Reset Done Ack - Sent" message to CSME */ : /* 20: ACM Active indication - ACM started its execution */ : /* 21: ACM Done indication - ACM completed execution */ : /* 22: BIOS sent DRAM Init Done message */ : /* 23: CSME sent DRAM Init Done message back to BIOS */ : /* 24: CSME completed loading TCSS */ : /* 25: CSME started loading ISH Bringup module */ : /* 26: CSME completed loading ISH Bringup module */ : /* 27: CSME started loading ISH Main module */ : /* 28: CSME completed loading Main module */ : /* 29: BIOS sent "End Of Post" message to CSME */ : /* 30: CSME sent "End Of Post" ack message back to BIOS */ : /* 31: BIOS sent "Core BIOS Done" message to CSME */ : /* 32: CSME sent "Core BIOS Done" ack message back to BIOS */ : /* 33: CSME reached Firmware Init Done */ : /* 34 - 63 Reserved */
Should we make these an enum ?
sure, done.
-
Bora Guvendik (Code Review)