4 Jun
2019
4 Jun
'19
10:14 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )
Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit ......................................................................
Patch Set 24: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30414/24/Documentation/mainboard/facebook/fb... File Documentation/mainboard/facebook/fbg1701.md:
https://review.coreboot.org/#/c/30414/24/Documentation/mainboard/facebook/fb... PS24, Line 75: | Super I/O | None | rephrase to "Super I/O, EC" as it's combined in one chip to avoid confusion.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28ac78a630ee705b1e546031f024bfe7f952ab39
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 24
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Alex Thiessen alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Tue, 04 Jun 2019 10:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
2034
days inactive
2034
days old
0 comments
1 participants
participants (1)
-
Patrick Rudolph (Code Review)