Change in coreboot[master]: mb/google/puff/var/noibat: Update DPTF parameters for noibat

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

mb/google/puff/var/noibat: Update DPTF parameters for noibat

1. Update paramerters form thermal team.
2. Update PL2 Max/Min to 51W/15W.

BUG=none
TEST=build noibat and verified by thermal team.

Signed-off-by: Wisley Chen 
Change-Id: Id96e681e9a990a1a1eaeb22781b1c60a7369118b
---
M src/mainboard/google/hatch/variants/noibat/overridetree.cb
1 file changed, 18 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45020/1

diff --git a/src/mainboard/google/hatch/variants/noibat/overridetree.cb b/src/mainboard/google/hatch/variants/noibat/overridetree.cb
index de49462..3b9e93c 100644
--- a/src/mainboard/google/hatch/variants/noibat/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/noibat/overridetree.cb
@@ -1,4 +1,8 @@
 chip soc/intel/cannonlake
+	register "power_limits_config" = "{
+		.tdp_pl1_override = 15,
+		.tdp_pl2_override = 51,
+	}"

# Auto-switch between X4 NVMe and X2 NVMe.
    register "TetonGlacierMode" = "1"
@@ -197,29 +201,27 @@
    		chip drivers/intel/dptf
    			## Active Policy
    			register "policies.active[0]" = "{.target=DPTF_CPU,
-					.thresholds={TEMP_PCT(90, 85),
-						     TEMP_PCT(85, 75),
-						     TEMP_PCT(80, 65),
-						     TEMP_PCT(75, 55),
-						     TEMP_PCT(70, 45),}}"
+				        .thresholds={TEMP_PCT(94, 0),}}"
    			register "policies.active[1]" = "{.target=DPTF_TEMP_SENSOR_0,
-					.thresholds={TEMP_PCT(50, 85),
-						     TEMP_PCT(47, 75),
-						     TEMP_PCT(45, 65),
-						     TEMP_PCT(42, 55),
-						     TEMP_PCT(39, 45),}}"
+					.thresholds={TEMP_PCT(65, 90),
+						     TEMP_PCT(52, 80),
+						     TEMP_PCT(50, 70),
+						     TEMP_PCT(48, 60),
+						     TEMP_PCT(46, 50),
+						     TEMP_PCT(44, 40),
+						     TEMP_PCT(42, 0),}}"

## Passive Policy
-				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU,           93, 5000)"
-				register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 65, 6000)"
+				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU,           95, 5000)"
+				register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 68, 5000)"

## Critical Policy
    			register "policies.critical[0]" = "DPTF_CRITICAL(CPU,          100, SHUTDOWN)"
-				register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN)"
+				register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 78, SHUTDOWN)"

## Power Limits Control
    			# PL1 is fixed at 15W, avg over 28-32s interval
-				# 25-64W PL2 in 1000mW increments, avg over 28-32s interval
+				# 15-51W PL2 in 1000mW increments, avg over 28-32s interval
    			register "controls.power_limits.pl1" = "{
    				.min_power = 15000,
    				.max_power = 15000,
@@ -227,8 +229,8 @@
    				.time_window_max = 32 * MSECS_PER_SEC,
    				.granularity = 200,}"
    			register "controls.power_limits.pl2" = "{
-					.min_power = 25000,
-					.max_power = 64000,
+					.min_power = 15000,
+					.max_power = 51000,
    				.time_window_min = 28 * MSECS_PER_SEC,
    				.time_window_max = 32 * MSECS_PER_SEC,
    				.granularity = 1000,}"

[Chen Wisley (Code Review)]

Chen Wisley has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

mb/google/puff/var/noibat: Update DPTF parameters for noibat

1. Update paramerters form thermal team.
2. Update PL2 Max/Min to 51W/15W.

BUG=none
TEST=build noibat and verified by thermal team.

Signed-off-by: Wisley Chen 
Change-Id: Id96e681e9a990a1a1eaeb22781b1c60a7369118b
---
M src/mainboard/google/hatch/variants/noibat/overridetree.cb
1 file changed, 18 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45020/2

[Chen Wisley (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45020

to look at the new patch set (#3).

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

mb/google/puff/var/noibat: Update DPTF parameters for noibat

1. Update paramerters form thermal team.
2. Update PL2 Max/Min to 51W/15W.

BUG=b:167494420
TEST=build noibat and verified by thermal team.

Signed-off-by: Wisley Chen 
Change-Id: Id96e681e9a990a1a1eaeb22781b1c60a7369118b
---
M src/mainboard/google/hatch/variants/noibat/overridetree.cb
1 file changed, 18 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45020/3

[Sam McNally (Code Review)]

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45020/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45020/3//COMMIT_MSG@14 
PS3, Line 14: 
BRANCH=puff

[Chen Wisley (Code Review)]

Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Andrew McRae,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45020

to look at the new patch set (#4).

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

mb/google/puff/var/noibat: Update DPTF parameters for noibat

1. Update paramerters form thermal team.
2. Update PL2 Max/Min to 51W/15W.

BUG=b:167494420
BRANCH=puff
TEST=build noibat and verified by thermal team.

Signed-off-by: Wisley Chen 
Change-Id: Id96e681e9a990a1a1eaeb22781b1c60a7369118b
---
M src/mainboard/google/hatch/variants/noibat/overridetree.cb
1 file changed, 18 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45020/4

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45020/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45020/3//COMMIT_MSG@14 
PS3, Line 14:
> BRANCH=puff

Done

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

Patch Set 4: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

mb/google/puff/var/noibat: Update DPTF parameters for noibat

1. Update paramerters form thermal team.
2. Update PL2 Max/Min to 51W/15W.

BUG=b:167494420
BRANCH=puff
TEST=build noibat and verified by thermal team.

Signed-off-by: Wisley Chen 
Change-Id: Id96e681e9a990a1a1eaeb22781b1c60a7369118b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45020
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Sam McNally 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/variants/noibat/overridetree.cb
1 file changed, 18 insertions(+), 16 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Edward O'Callaghan: Looks good to me, approved
  Sam McNally: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/noibat/overridetree.cb b/src/mainboard/google/hatch/variants/noibat/overridetree.cb
index de49462..e206ea5 100644
--- a/src/mainboard/google/hatch/variants/noibat/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/noibat/overridetree.cb
@@ -1,4 +1,8 @@
 chip soc/intel/cannonlake
+	register "power_limits_config" = "{
+		.tdp_pl1_override = 15,
+		.tdp_pl2_override = 51,
+	}"

# Auto-switch between X4 NVMe and X2 NVMe.
    register "TetonGlacierMode" = "1"
@@ -197,29 +201,27 @@
    		chip drivers/intel/dptf
    			## Active Policy
    			register "policies.active[0]" = "{.target=DPTF_CPU,
-					.thresholds={TEMP_PCT(90, 85),
-						     TEMP_PCT(85, 75),
-						     TEMP_PCT(80, 65),
-						     TEMP_PCT(75, 55),
-						     TEMP_PCT(70, 45),}}"
+					.thresholds={TEMP_PCT(94, 0),}}"
    			register "policies.active[1]" = "{.target=DPTF_TEMP_SENSOR_0,
-					.thresholds={TEMP_PCT(50, 85),
-						     TEMP_PCT(47, 75),
-						     TEMP_PCT(45, 65),
-						     TEMP_PCT(42, 55),
-						     TEMP_PCT(39, 45),}}"
+					.thresholds={TEMP_PCT(65, 90),
+						     TEMP_PCT(52, 80),
+						     TEMP_PCT(50, 70),
+						     TEMP_PCT(48, 60),
+						     TEMP_PCT(46, 50),
+						     TEMP_PCT(44, 40),
+						     TEMP_PCT(42, 0),}}"

## Passive Policy
-				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU,           93, 5000)"
-				register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 65, 6000)"
+				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU,           95, 5000)"
+				register "policies.passive[1]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 68, 5000)"

## Critical Policy
    			register "policies.critical[0]" = "DPTF_CRITICAL(CPU,          100, SHUTDOWN)"
-				register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 75, SHUTDOWN)"
+				register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_0, 78, SHUTDOWN)"

## Power Limits Control
    			# PL1 is fixed at 15W, avg over 28-32s interval
-				# 25-64W PL2 in 1000mW increments, avg over 28-32s interval
+				# 15-51W PL2 in 1000mW increments, avg over 28-32s interval
    			register "controls.power_limits.pl1" = "{
    				.min_power = 15000,
    				.max_power = 15000,
@@ -227,8 +229,8 @@
    				.time_window_max = 32 * MSECS_PER_SEC,
    				.granularity = 200,}"
    			register "controls.power_limits.pl2" = "{
-					.min_power = 25000,
-					.max_power = 64000,
+					.min_power = 15000,
+					.max_power = 51000,
    				.time_window_min = 28 * MSECS_PER_SEC,
    				.time_window_max = 32 * MSECS_PER_SEC,
    				.granularity = 1000,}"

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45020 )

Change subject: mb/google/puff/var/noibat: Update DPTF parameters for noibat
......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17636
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17635
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17634
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17633
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17632
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17639
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17638
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17637

Please note: This test is under development and might not be accurate at all!