Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Dtrain Hsu (Code Review)

16 Jan 2019 16 Jan '19

10:19 a.m.

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30949

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Sarien EVT TS: 380.7 KHz TP: 379.3 KHz H1: 392.2 KHz

BUG=b:122657195 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30949/1

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index b590bac..425881a 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -75,17 +75,19 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 190, + .fall_time_ns = 120, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 176, - .fall_time_ns = 15, + .rise_time_ns = 52, + .fall_time_ns = 110, }, .i2c[4] = { .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 280, - .fall_time_ns = 90, + .rise_time_ns = 36, + .fall_time_ns = 99, }, }"

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Lijian Zhao (Code Review)

16 Jan 16 Jan

5:38 p.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG@10 PS1, Line 10: TS TouchScreen

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG@11 PS1, Line 11: TP TouchPad

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 16 Jan 2019 17:38:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

17 Jan 17 Jan

1:43 a.m.

Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30949

to look at the new patch set (#2).

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Sarien EVT TouchScreen: 380.7 KHz TouchPad: 379.3 KHz H1: 392.2 KHz

BUG=b:122657195 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30949/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

Dtrain Hsu (Code Review)

1:43 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 2:

(2 comments)

...

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG@10 PS1, Line 10: TS

...

TouchScreen

Done

https://review.coreboot.org/#/c/30949/1//COMMIT_MSG@11 PS1, Line 11: TP

...

TouchPad

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 17 Jan 2019 01:43:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lijian Zhao lijian.zhao@intel.com Gerrit-MessageType: comment

Lijian Zhao (Code Review)

2:42 a.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 17 Jan 2019 02:42:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

2:44 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 17 Jan 2019 02:44:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:15 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 17 Jan 2019 11:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

18 Jan 18 Jan

2:39 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

Patch Set 2:

Please help me to merge it. Thanks a lot.

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Fri, 18 Jan 2019 02:39:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

4:01 a.m.

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30949 )

Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec ......................................................................

mb/google/sarien/variants/sarien: Adjust TP/TS/H1 I2C CLK to meet spec

After adjustment on Sarien EVT TouchScreen: 380.7 KHz TouchPad: 379.3 KHz H1: 392.2 KHz

BUG=b:122657195 BRANCH=master TEST=emerge-sarien coreboot chromeos-bootimage measure by scope

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Reviewed-on: https://review.coreboot.org/c/30949 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 6 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Lijian Zhao: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 4334c45..59f1f30 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -81,17 +81,19 @@ .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 190, + .fall_time_ns = 120, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 176, - .fall_time_ns = 15, + .rise_time_ns = 52, + .fall_time_ns = 110, }, .i2c[4] = { .early_init = 1, .speed = I2C_SPEED_FAST, - .rise_time_ns = 280, - .fall_time_ns = 90, + .rise_time_ns = 36, + .fall_time_ns = 99, }, }"

-- To view, visit https://review.coreboot.org/c/coreboot/+/30949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dd92b054d934b38a17898dc8ce9cc18bda1633f Gerrit-Change-Number: 30949 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: merged

2143

days inactive

2145

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Dtrain Hsu (Code Review)
Duncan Laurie (Code Review)
Lijian Zhao (Code Review)
Paul Menzel (Code Review)