Change in coreboot[master]: drivers/intel/fsp2_0: Avoid iterative print statement

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

drivers/intel/fsp2_0: Avoid iterative print statement

This patch keeps "Display FSP Version Info HOB" print outside loop
to avoid getting called multiple times.

TEST=Able to see "Display FSP Version Info HOB" only once.

Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d
Signed-off-by: Subrata Banik 
---
M src/drivers/intel/fsp2_0/hand_off_block.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39827/1

diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index d2c2b78..3978a18 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -233,7 +233,6 @@
    		 (fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
    size -= sizeof(SMBIOS_STRUCTURE);

-	printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
    for (index = 0; index < fvih->Count; index++) {
    	cnt = strlen(str_ptr);

@@ -282,6 +281,7 @@
    if (!hob)
    	return;

+	printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
    for (; hob->type != HOB_TYPE_END_OF_HOB_LIST;
    		hob = fsp_next_hob(hob)) {
    	if (hob->type != HOB_TYPE_GUID_EXTENSION)

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG@9 
PS1, Line 9: This patch keeps "Display FSP Version Info HOB" print outside loop
outside the loop

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG@9 
PS1, Line 9: This patch keeps "Display FSP Version Info HOB" print outside loop
> outside the loop

rather: outside of the loop

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG@9 
PS1, Line 9: keeps
moves

[Subrata Banik (Code Review)]

Hello V Sowmya, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Paul Menzel, Angel Pons, Andrey Petrov, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39827

to look at the new patch set (#2).

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

drivers/intel/fsp2_0: Avoid iterative print statement

This patch moves "Display FSP Version Info HOB" print outside
of the loop to avoid getting called multiple times.

TEST=Able to see "Display FSP Version Info HOB" only once.

Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d
Signed-off-by: Subrata Banik 
---
M src/drivers/intel/fsp2_0/hand_off_block.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/39827/2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG@9 
PS1, Line 9: This patch keeps "Display FSP Version Info HOB" print outside loop
> rather: outside of the loop

Ack

https://review.coreboot.org/c/coreboot/+/39827/1//COMMIT_MSG@9 
PS1, Line 9: keeps
> moves

Ack

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 2: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 2: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

drivers/intel/fsp2_0: Avoid iterative print statement

This patch moves "Display FSP Version Info HOB" print outside
of the loop to avoid getting called multiple times.

TEST=Able to see "Display FSP Version Info HOB" only once.

Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39827
Reviewed-by: Angel Pons 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/fsp2_0/hand_off_block.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index d2c2b78..3978a18 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -233,7 +233,6 @@
    		 (fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
    size -= sizeof(SMBIOS_STRUCTURE);

-	printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
    for (index = 0; index < fvih->Count; index++) {
    	cnt = strlen(str_ptr);

@@ -282,6 +281,7 @@
    if (!hob)
    	return;

+	printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
    for (; hob->type != HOB_TYPE_END_OF_HOB_LIST;
    		hob = fsp_next_hob(hob)) {
    	if (hob->type != HOB_TYPE_GUID_EXTENSION)

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39827 )

Change subject: drivers/intel/fsp2_0: Avoid iterative print statement
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 5/0/5
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1836
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1835
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1834
Non-emulation targets:
HP_COMPAQ_8200_ELITE_SFF_PC using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1838
HP_COMPAQ_8200_ELITE_SFF_PC using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1837

Please note: This test is under development and might not be accurate at all!