Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim.
Subrata Banik has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email )
Change subject: mb/google/fatcat: Enable PCH Energy Report
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85615/comment/b265ed61_8faacba3?usp... :
PS1, Line 38:
: # TODO: Safe Setting. Needs to be removed later
: # Disable C1 C-state auto-demotion
: register "disable_c1_state_auto_demotion" = "true"
Let me check this with PTL and update.
Acknowledged
https://review.coreboot.org/c/coreboot/+/85615/comment/2e87b0e3_7d5135c7?usp... :
PS1, Line 42: # Enable Energy Reporting
: register "pch_pm_energy_report_enable" = "true"
can you please submit this CL for review
Acknowledged
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85615/comment/28009fae_dd55617d?usp... :
PS3, Line 44:
please drop this empty line ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85615?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie318f21cf00a74fd68c86dd39efb5e020e444085
Gerrit-Change-Number: 85615
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hima B Chilmakuru
hima.b.chilmakuru@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Hima B Chilmakuru
hima.b.chilmakuru@intel.com
Gerrit-Comment-Date: Fri, 24 Jan 2025 04:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com