Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39577 )
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
mb/purism: remove duplicate ACPI power button
These platforms use the standard fixed function power button and do not need a second power button device declared or the kernel will end up with two devices reporting the same event.
Change-Id: I17c85e43493530d04f4fa13f33bec6d027cb3147 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_bdw/acpi/mainboard.asl M src/mainboard/purism/librem_skl/acpi/mainboard.asl 2 files changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39577/1
diff --git a/src/mainboard/purism/librem_bdw/acpi/mainboard.asl b/src/mainboard/purism/librem_bdw/acpi/mainboard.asl index f0b2c1d..0e4842d 100644 --- a/src/mainboard/purism/librem_bdw/acpi/mainboard.asl +++ b/src/mainboard/purism/librem_bdw/acpi/mainboard.asl @@ -30,18 +30,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E")) diff --git a/src/mainboard/purism/librem_skl/acpi/mainboard.asl b/src/mainboard/purism/librem_skl/acpi/mainboard.asl index f0b2c1d..0e4842d 100644 --- a/src/mainboard/purism/librem_skl/acpi/mainboard.asl +++ b/src/mainboard/purism/librem_skl/acpi/mainboard.asl @@ -30,18 +30,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E"))
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39577 )
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39577/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39577/1//COMMIT_MSG@12 PS1, Line 12: Mention commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) (https://review.coreboot.org/27272), which has more details?
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39577
to look at the new patch set (#2).
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
mb/purism: remove duplicate ACPI power button
These platforms use the standard fixed function power button and do not need a second power button device declared or the kernel will end up with two devices reporting the same event.
Same change was applied to all google mainboards in CB:27272 which contains more detail.
Change-Id: I17c85e43493530d04f4fa13f33bec6d027cb3147 Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_bdw/acpi/mainboard.asl M src/mainboard/purism/librem_skl/acpi/mainboard.asl 2 files changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/39577/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39577 )
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39577/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39577/1//COMMIT_MSG@12 PS1, Line 12:
Mention commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) (https:// […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39577 )
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39577 )
Change subject: mb/purism: remove duplicate ACPI power button ......................................................................
mb/purism: remove duplicate ACPI power button
These platforms use the standard fixed function power button and do not need a second power button device declared or the kernel will end up with two devices reporting the same event.
Same change was applied to all google mainboards in CB:27272 which contains more detail.
Change-Id: I17c85e43493530d04f4fa13f33bec6d027cb3147 Signed-off-by: Matt DeVillier matt.devillier@puri.sm Reviewed-on: https://review.coreboot.org/c/coreboot/+/39577 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_bdw/acpi/mainboard.asl M src/mainboard/purism/librem_skl/acpi/mainboard.asl 2 files changed, 0 insertions(+), 24 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_bdw/acpi/mainboard.asl b/src/mainboard/purism/librem_bdw/acpi/mainboard.asl index f0b2c1d..0e4842d 100644 --- a/src/mainboard/purism/librem_bdw/acpi/mainboard.asl +++ b/src/mainboard/purism/librem_bdw/acpi/mainboard.asl @@ -30,18 +30,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E")) diff --git a/src/mainboard/purism/librem_skl/acpi/mainboard.asl b/src/mainboard/purism/librem_skl/acpi/mainboard.asl index f0b2c1d..0e4842d 100644 --- a/src/mainboard/purism/librem_skl/acpi/mainboard.asl +++ b/src/mainboard/purism/librem_skl/acpi/mainboard.asl @@ -30,18 +30,6 @@ } }
- Device (PWRB) - { - Name (_HID, EisaId ("PNP0C0C")) - - Method (_STA) - { - Return (0xF) - } - - Name (_PRW, Package () { 27, 4 }) - } - Device (SLPB) { Name (_HID, EisaId ("PNP0C0E"))
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)