Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro.
Hello Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70276
to look at the new patch set (#2).
Change subject: drivers/intel/gma: Hook up libgfxinit in romstage
......................................................................
drivers/intel/gma: Hook up libgfxinit in romstage
A mainboard port needs to:
- select `CONFIG_ROMSTAGE_MAINBOARD_HAS_LIBGFXINIT'
- implement the Ada package `GMA.Mainboard' with a single function
`ports' that returns a list of ports to be probed for displays.
- set the desired `GFX_GMA_DEFAULT_MMIO' IO memory address to use
in romstage for the graphic device.
This CL requires the libgfxinit
https://review.coreboot.org/c/libgfxinit/+/69855 patch.
BUG=b:252792591
BRANCH=firmware-brya-14505.B
TEST=TO-BE-COMPLETED
Change-Id: I3c2101de10dc5df54fe873e43bbe0f1c4dccff44
Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com
---
M src/arch/x86/car.ld
M src/device/Kconfig
M src/drivers/intel/gma/Kconfig
M src/drivers/intel/gma/Makefile.inc
4 files changed, 107 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/70276/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c2101de10dc5df54fe873e43bbe0f1c4dccff44
Gerrit-Change-Number: 70276
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: newpatchset