Attention is currently required from: Felix Singer, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, Aaron Durbin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58020 )
Change subject: soc/intel: implement ACPI timer disabling per SoC and drop common code
......................................................................
Patch Set 18:
(1 comment)
Patchset:
PS17:
well, how would you fix that? by always passing the addresses to common code everywhere instead of u […]
Just move the declaration where it belongs: CB:58388. I tried to do it without
adding a new file, but it seemed cleaner.
Given that we usually have a static address, having a global pmc_mmio_regs()
seems ok. However, actually correct would be to have a single pmc_mmio_regs()
implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I434ea87d00f6e919983d9229f79d4adb352fbf27
Gerrit-Change-Number: 58020
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sun, 17 Oct 2021 11:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment