Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78254?usp=email )
Change subject: mb/google/rex/var/karis: Set touchscreen power/reset GPIOs correctly ......................................................................
mb/google/rex/var/karis: Set touchscreen power/reset GPIOs correctly
The tochscreen isn't powered on yet when the detection is done, it makes touchscren no function.
Set touchscreen power and reset GPIOs correctly in romstage and ramstage to make the detect feature works.
BUG=b:303130400 TEST=(1) emerge-rex coreboot (2) Test on karis, touchscreen function works
Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7 Signed-off-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78254 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/variants/karis/gpio.c 1 file changed, 6 insertions(+), 2 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/karis/gpio.c b/src/mainboard/google/rex/variants/karis/gpio.c index 4e5eb68..2a94cae 100644 --- a/src/mainboard/google/rex/variants/karis/gpio.c +++ b/src/mainboard/google/rex/variants/karis/gpio.c @@ -96,9 +96,9 @@ PAD_NC(GPP_B23, NONE),
/* GPP_C00 : [] ==> EN_TCHSCR_PWR */ - PAD_CFG_GPO(GPP_C00, 0, DEEP), + PAD_CFG_GPO(GPP_C00, 1, DEEP), /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */ - PAD_CFG_GPO(GPP_C01, 0, DEEP), + PAD_CFG_GPO(GPP_C01, 1, DEEP), /* GPP_C02 : SOC_TCHSCR_SPI_INT_STRAP ==> Component NC */ PAD_NC(GPP_C02, NONE), /* GPP_C03 : [] ==> Test pad. */ @@ -399,6 +399,10 @@ PAD_CFG_GPO(GPP_A20, 0, DEEP), /* GPP_C23 : [] ==> FP_RST_ODL */ PAD_CFG_GPO(GPP_C23, 0, DEEP), + /* GPP_C00 : [] ==> EN_TCHSCR_PWR */ + PAD_CFG_GPO(GPP_C00, 1, DEEP), + /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */ + PAD_CFG_GPO(GPP_C01, 0, DEEP), /* GPP_D02 : Not Connected */ PAD_NC(GPP_D02, NONE), };