build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25208 )
Change subject: sdm845: Add QCLib to RomStage to perform IP init
......................................................................
Patch Set 72:
(2 comments)
https://review.coreboot.org/#/c/25208/72/src/soc/qualcomm/sdm845/soc_blob_lo...
File src/soc/qualcomm/sdm845/soc_blob_load.c:
https://review.coreboot.org/#/c/25208/72/src/soc/qualcomm/sdm845/soc_blob_lo...
PS72, Line 29: printk(BIOS_INFO, "soc_blob_load(sdm845)\n");
Prefer using '"%s...", __func__' to using 'soc_blob_load', this function's name, in a string
https://review.coreboot.org/#/c/25208/72/src/soc/qualcomm/sdm845/soc_blob_lo...
PS72, Line 57: die("Couldn't run soc_blob_load.\n");
Prefer using '"%s...", __func__' to using 'soc_blob_load', this function's name, in a string
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I073186674a1a593547d1ee1d15c7cd4fd8ad5bc1
Gerrit-Change-Number: 25208
Gerrit-PatchSet: 72
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T Michael Turney
mturney@codeaurora.org
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 11 Apr 2019 21:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment