[M] Change in coreboot[master]: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin
Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 )
Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73451/comment/11ab350a_16e22371 PS2, Line 9: was lacking
Present tense would be for the things that the commit does. […]
Ack
https://review.coreboot.org/c/coreboot/+/73451/comment/e2e8752b_d7bd3776 PS2, Line 10: could not
Ditto.
Ack
https://review.coreboot.org/c/coreboot/+/73451/comment/b2cea355_c271605a PS2, Line 18: VGABIOS
Note for the future: we usually extract VBTs from Linux sysfs `/sys/kernel/debug/dri/0/i915_vbt` bec […]
Ack
File src/mainboard/asrock/b75pro3-m/cmos.layout:
https://review.coreboot.org/c/coreboot/+/73451/comment/b9bd020b_48cf8f65 PS2, Line 28: 421 2 e 7 cpu_fan_tach_src
Why add this option if it's unused?
It was inherited from the h77pro4-m port. I've fixed this in https://review.coreboot.org/c/coreboot/+/73931
-
Kevin Keijzer (Code Review)