Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27888
to look at the new patch set (#3).
Change subject: cbmem: rename vdat to chromeos_acpi ......................................................................
cbmem: rename vdat to chromeos_acpi
There is a confusingly named section in cbmem called vdat. This section holds a data structure called chromeos_acpi_t, which exposes some system information to the Chrome OS userland utility crossystem.
Within the chromeos_acpi_t structure, there is a member called vdat. This (currently) holds a VbSharedDataHeader.
Rename the outer vdat to chromeos_acpi to make its purpose clear, and prevent the bizarreness of being able to access vdat->vdat.
Additionally, disallow external references to the chromeos_acpi data structure in gnvs.c.
BUG=b:112288216 TEST=emerge-eve coreboot, run on eve CQ-DEPEND=CL:1164722
Signed-off-by: Joel Kitching kitching@google.com
Change-Id: Ia74e58cde21678f24b0bb6c1ca15048677116b2e --- M payloads/libpayload/include/coreboot_tables.h M payloads/libpayload/include/sysinfo.h M payloads/libpayload/libc/coreboot.c M src/arch/x86/smbios.c M src/commonlib/include/commonlib/coreboot_tables.h M src/lib/coreboot_table.c M src/vendorcode/google/chromeos/gnvs.c M src/vendorcode/google/chromeos/gnvs.h 8 files changed, 42 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/27888/3