Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 56:
(45 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/28d3f09c_06a0d1a6 PS56, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/57b23435_ce119b23 PS56, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/a8aceebe_be94245b PS56, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/ac4760ac_2c9575c4 PS56, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4e41ae81_655da886 PS56, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/c8bd3b15_6f6634c5 PS56, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/e2027fef_cf72432a PS56, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/9a8cd8eb_5f31e6c6 PS56, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/ebf38eaa_a218258d PS56, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/07c45d24_883b54f3 PS56, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4b1f410c_2231edee PS56, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/88499b82_7b5fe652 PS56, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/35da6393_6b12a62e PS56, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/7fa4b83a_e5adf72f PS56, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6e76734e_9e17a9d2 PS56, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwEc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6173bf9d_613d7bf7 PS56, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/da728232_43c718e4 PS56, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/f90eabea_058580c8 PS56, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/80a47834_74eff8c6 PS56, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6ab86f69_579d39a8 PS56, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/fb39fd7c_cc9364eb PS56, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/0e443c01_5f686be1 PS56, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/2c7f9e35_6c523cbc PS56, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/d8ffbe42_134348e6 PS56, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/6c229b79_73a7cda6 PS56, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/2629d8f1_abe62d66 PS56, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/09910b3f_50c6ee14 PS56, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/212f55c0_5d8ffd31 PS56, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/479ee03d_246d01fe PS56, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/d426eeb0_5ba92c55 PS56, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/8736add3_46a5f38a PS56, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/5d00cfd0_cfa43d15 PS56, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/a194c0cc_3f0d1110 PS56, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/8bca37a4_16ddafc9 PS56, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/4518ff0b_184bcd7e PS56, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/3841f0af_f33b63d9 PS56, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/894011d7_d614b076 PS56, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/206740ad_9608a9f7 PS56, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/0b793d48_f755c0c2 PS56, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/9c0f402f_130447a3 PS56, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/76d5e9cb_e1a59c26 PS56, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/542b7762_4f506278 PS56, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/fa7ca3a1_1032421f PS56, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/7ffe1442_c398708a PS56, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159862): https://review.coreboot.org/c/coreboot/+/23586/comment/42f3fb18_206b8491 PS56, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
-
build bot (Jenkins) (Code Review)