Change in coreboot[master]: payloads/external/linux: Attempt to autodetect correct toolchain
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38531 )
Change subject: payloads/external/linux: Attempt to autodetect correct toolchain ......................................................................
payloads/external/linux: Attempt to autodetect correct toolchain
Change-Id: Ide7cd9ff838266823057d604addc8970939ccb86 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38531/1
diff --git a/payloads/external/LinuxBoot/targets/linux.mk b/payloads/external/LinuxBoot/targets/linux.mk index 8be0926..aa3f168 100644 --- a/payloads/external/LinuxBoot/targets/linux.mk +++ b/payloads/external/LinuxBoot/targets/linux.mk @@ -27,6 +27,18 @@ project_dir=linuxboot tarball_dir:=$(project_dir)/tarball decompress_flag=.done +ifeq ($(LINUXBOOT_CROSS_COMPILE),) +$(info env LINUXBOOT_CROSS_COMPILE not set, auto-detecting host toolchain...) +# Don't use gnu-gcc as ccache falsely provides this single binary +ifeq ($(CONFIG_LINUXBOOT_X86_64),y) +LINUXBOOT_CROSS_COMPILE=$(shell which x86_64-linux-gnu-ld | sed -e "s/linux-gnu-ld/linux-gnu-/g") +else ifeq ($(CONFIG_LINUXBOOT_X86),y) +LINUXBOOT_CROSS_COMPILE=$(shell which i386-linux-gnu-ld | sed -e "s/linux-gnu-ld/linux-gnu-/g") +else ifeq ($(CONFIG_LINUXBOOT_ARM64),y) +LINUXBOOT_CROSS_COMPILE=$(shell which aarch64-linux-gnu-ld | sed -e "s/linux-gnu-ld/linux-gnu-/g") +endif +$(info Using '$(LINUXBOOT_CROSS_COMPILE)' as toolchain) +endif
OBJCOPY:=$(LINUXBOOT_CROSS_COMPILE)objcopy KERNEL_MAKE_FLAGS = \
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38531
to look at the new patch set (#2).
Change subject: payloads/external/linux: Attempt to autodetect correct toolchain ......................................................................
payloads/external/linux: Attempt to autodetect correct toolchain
Search for $(arch)-linux-gnu-ld in path.
Tested on Fedora 31: There's no need to specify a cross toolchain using LINUXBOOT_CROSS_COMPILE any more, however if it's specified there will be no autodetection.
Change-Id: Ide7cd9ff838266823057d604addc8970939ccb86 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M payloads/external/LinuxBoot/targets/linux.mk 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38531/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38531 )
Change subject: payloads/external/linux: Attempt to autodetect correct toolchain ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38531/2/payloads/external/LinuxBoot... File payloads/external/LinuxBoot/targets/linux.mk:
https://review.coreboot.org/c/coreboot/+/38531/2/payloads/external/LinuxBoot... PS2, Line 39: endif else, error?
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38531?usp=email )
Change subject: payloads/external/linux: Attempt to autodetect correct toolchain ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Martin L Roth (Code Review)
-
Patrick Rudolph (Code Review)