Attention is currently required from: Derek Huang, Paul Menzel, Reka Norman.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )
Change subject: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/dedede/variants/boxy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78146/comment/a46399d8_25ae3b2d :
PS5, Line 69: if (display_init_required()
: && !gpio_get(GPIO_USB_C0_HPD)) {
: /* This has to be done before FSP-S runs. */
: if (google_chromeec_wait_for_displayport(display_timeout_ms)) {
: wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms);
: }
: } else if (display_init_required()
: && !gpio_get(GPIO_USB_C1_HPD)) {
: /* This has to be done before FSP-S runs. */
: if (google_chromeec_wait_for_displayport(display_timeout_ms)) {
: wait_for_hpd(GPIO_USB_C1_HPD, display_timeout_ms);
: }
: }
We have 1 HDMI and 2 Type-C ports for boxy project. […]
Also we will not have cases connected to two type-c monitors since boxy need 1 type-c port to be connected to adapter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208fdf8234886b2ef43a4b972e6682892238e8e9
Gerrit-Change-Number: 78146
Gerrit-PatchSet: 8
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 06 Oct 2023 10:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment