Change in coreboot[master]: tests/console: Add tests for log message routing behavior - coreboot-gerrit

11 Jun 2021


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55356 )
Change subject: tests/console: Add tests for log message routing behavior
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4: 
Woah, guys, what happened to the "never change the actual code just to accommodate tests" principle? Especially not in a way that adds extra function call overhead to an very frequently called piece of code? I thought we had already established the "include the source file" method of accessing static variables and functions from tests (e.g. like in CB:46458), wouldn't that have sufficed here as well?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id978cfe4fa45fef9edbc3d3b55606ff6973521c5
Gerrit-Change-Number: 55356
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Fri, 11 Jun 2021 23:29:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment