Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )
Change subject: drivers/intel/mipi_camera: camera SSDT generation ......................................................................
Patch Set 11:
(6 comments)
A few nits.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 40: = 0; no need to initialize.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 42: struct acpi_dp *ep_table = NULL; : struct acpi_dp *port_table = NULL; : struct acpi_dp *remote = NULL; Initializing these as NULL only makes sense if you do a NULL check after acpi_dp_new_table() which does not seem like a bad idea.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 48: strdup check for NULL?
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 50: acpi_dp_add_integer It seems uncommon to do but do you want to check the return value?
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 91: *config check for NULL.
https://review.coreboot.org/c/coreboot/+/41607/11/src/drivers/intel/mipi_cam... PS11, Line 216: config check for NULL.
-
Arthur Heymans (Code Review)