Attention is currently required from: Arthur Heymans, Leah Rowe, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81644?usp=email )
Change subject: nb/haswell: Fully disable iGPU when dGPU is used ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81644/comment/d0461f6f_7d27d7c2 : PS1, Line 9: My earlier patch It's hard to know what "my earlier patch" refers to without reading the rest of the commit message first. So, I would preface the commit message with something like:
This commit brings some parts of commit 1e2821882f (nb/haswell: Disable iGPU when dGPU is used) that were lost during review.
I'm not too inspired today, feel free to reword.
https://review.coreboot.org/c/coreboot/+/81644/comment/38b5dcbd_02762878 : PS1, Line 11: you also need to disable the iGPU entirely.
What do you mean by 'need to' ? Also a dGPU does not need to be on the PEG slot and probably works f […]
Without this patch, what happens on a system with both an iGPU and a dGPU?
https://review.coreboot.org/c/coreboot/+/81644/comment/611badf3_1c02676f : PS1, Line 18: For more context, see: : : Author: Leah Rowe info@minifree.org : Date: Fri Feb 23 13:33:31 2024 +0000 : : nb/haswell: Disable iGPU when dGPU is used : : And now, look at the Gerrit comments for explanation: : : https://review.coreboot.org/c/coreboot/+/80717/ Please use commit hashes to reference stuff. I can't find a specific recommendation in the docs, but I think shortening hashes to the first 10 characters is OK. If not, I think the bot will complain.
For more context, see commit 1e2821882f (nb/haswell: Disable iGPU when dGPU is used) and its review on Gerrit.
Notice how Gerrit highlights the commit part as a link? It's automatic 😊
https://review.coreboot.org/c/coreboot/+/81644/comment/484316e1_2beff0db : PS1, Line 30: This patch fixes the issue. I tested on iGPU and dGPU, with both : broadwell and haswell mrc.bin. Please make sure that, when `CONFIG_ONBOARD_VGA_IS_PRIMARY=y` (used for Optimus setups):
- The iGPU is enabled and primary - The dGPU is enabled
Even if the OptiPlex 9020 SFF is not an Optimus-enabled system, setting `CONFIG_ONBOARD_VGA_IS_PRIMARY=y` should still result in the same behaviour.
Patchset:
PS1: I would earnestly appreciate a thorough description of the issue you're encountering.
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/81644/comment/c1455e10_3c952c48 : PS1, Line 469: Required
It works when it's disabled? That might need additional context.
Please elaborate on "doesn't work".