Werner Zeh has posted comments on this change. ( https://review.coreboot.org/26244 )
Change subject: util/cbmem: Add cbmem TCPA log support ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/core... File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/#/c/26244/7/src/commonlib/include/commonlib/core... PS7, Line 313: Use tabs here as it is done before and after?
https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c File util/cbmem/cbmem.c:
https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@704 PS7, Line 704: die("Unable to map tcpa log header\n"); Shall we really die here? Can't you just return with an error and leave the system alive?
https://review.coreboot.org/#/c/26244/7/util/cbmem/cbmem.c@712 PS7, Line 712: die("Unable to map full tcpa log table\n"); Here, too.