Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52375 )
Change subject: sc7280: Add PCIe Root Complex driver in coreboot ......................................................................
Patch Set 4:
(60 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/f0a13fc6_efd85412 PS4, Line 65: #define PCIE1_IO_ADDR 0x40200000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/785e7bb0_39aae873 PS4, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/8a9ff344_be867ea3 PS4, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/c5b9f24c_90d593e8 PS4, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/faace053_60ef90f3 PS4, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/ec54032d_a9f650d2 PS4, Line 12: #define GPIO_PERST 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/ad2cb324_b67e6ffc PS4, Line 14: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/f2e9a223_c9be1a79 PS4, Line 14: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/f8307a4f_d05a3149 PS4, Line 94: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/d2be87fb_1a07c416 PS4, Line 106: #define PCIE_BUS_CFG(pri,sec,sub) ((sub & 0xFF)<<16|(sec & 0xFF)<<8|(pri&0xFF)) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/6d8da29d_48f62d20 PS4, Line 106: #define PCIE_BUS_CFG(pri,sec,sub) ((sub & 0xFF)<<16|(sec & 0xFF)<<8|(pri&0xFF)) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/f3e58ed8_3252732b PS4, Line 215: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/cec17a67_9d0da5e9 PS4, Line 216: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/5bb81a39_db10e875 PS4, Line 217: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/caa07561_36037716 PS4, Line 218: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/5da82612_6bec0572 PS4, Line 230: unsigned int offset; please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/include/soc/qcom_qmp_phy.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/3f1085fd_8c1516bb PS4, Line 61: #define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_TX 0x3c please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/b925ee9b_505ecd0f PS4, Line 62: #define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_RX 0x40 please, no space before tabs
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/2b67f2be_4bd6042b PS4, Line 89: }qmp_phy_cfg_t; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/ccbd7bc0_57f69f4b PS4, Line 249: .qmp_phy_base = (void *) PCIE_1_QMP_PHY, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/c6b53cdc_c2215715 PS4, Line 250: .serdes = (void *) PCE1_QPHY_SERDES, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/05a52041_ac4f11c0 PS4, Line 251: .tx0 = (void *) PCE1_QPHY_TX0, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/1b0699fe_f76351e7 PS4, Line 252: .rx0 = (void *) PCE1_QPHY_RX0, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/768cc836_ddc9ed7b PS4, Line 253: .pcs = (void *) PCIE1_QMP_PHY_PCS_COM, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/f0afcb79_876c3c12 PS4, Line 254: .tx1 = (void *) PCE1_QPHY_TX1, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/08dbb5ee_d0ca81c3 PS4, Line 255: .rx1 = (void *) PCE1_QPHY_RX1, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/a3d66800_7214b229 PS4, Line 256: .pcs_misc = (void *) PCE1_QPHY_PCS_MISC, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/adb766c9_3a449b56 PS4, Line 270: .pcs_tbl_num_sec= ARRAY_SIZE(sc7280_qmp_gen3x2_pcie_pcs_tbl), spaces required around that '=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/dd22a745_73e1acac PS4, Line 272: .pcs_misc_tbl_num= ARRAY_SIZE(sc7280_qmp_pcie_pcs_misc_tbl), spaces required around that '=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/1e1bfd91_87c426ec PS4, Line 444: printk(BIOS_INFO, "PCIE1: Assert the reset of EP \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/5fbf02bc_1521ab2d PS4, Line 676: if (!bar_response) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/b3fc26c9_d4c0cdc3 PS4, Line 902: const struct qcom_qmp_phy_init_tbl tbl[], int num, uint8_t ln_mask) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/30e2aeb2_78667927 PS4, Line 902: const struct qcom_qmp_phy_init_tbl tbl[], int num, uint8_t ln_mask) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/fc078379_1ab19b62 PS4, Line 908: if (!(t->lane_mask & ln_mask)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/a5dd73a4_8d667461 PS4, Line 966: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/645e7f06_4bbf3a73 PS4, Line 969: if (ret) { suspect code indent for conditional statements (8, 13)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/ea96a13d_b9219535 PS4, Line 970: printk(BIOS_ERR, " %s(): Pipe clock enable failed\n", __func__); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/7f50411e_41421c7c PS4, Line 971: return -1; Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/bab53154_b4d40ed1 PS4, Line 989: pcie_rc_config_t *pcierc = pcie->rc_cfg; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/06dd3e02_181495ac PS4, Line 989: pcie_rc_config_t *pcierc = pcie->rc_cfg; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/ce9b21a9_de720bc3 PS4, Line 990: uint64_t ep_config_base, ep_config_size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/4fb76569_9db8b104 PS4, Line 990: uint64_t ep_config_base, ep_config_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/a0ff43cb_f829ab40 PS4, Line 992: ep_config_base = (uint64_t)pcierc->cfg_base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/5792b550_bc57d749 PS4, Line 992: ep_config_base = (uint64_t)pcierc->cfg_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/45206ea2_7f411b46 PS4, Line 993: ep_config_size = pcierc->cfg_size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/e464a136_f41b09fd PS4, Line 993: ep_config_size = pcierc->cfg_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/b399fedf_e4ce6989 PS4, Line 996: qcom_dw_pcie_prog_outbound_atu(pcie, PCIE_ATU_REGION_INDEX1, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/41a2bd87_32c0acd7 PS4, Line 996: qcom_dw_pcie_prog_outbound_atu(pcie, PCIE_ATU_REGION_INDEX1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/679bcc65_b4c6718f PS4, Line 997: PCIE_ATU_TYPE_CFG0, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/50095193_5db97f57 PS4, Line 997: PCIE_ATU_TYPE_CFG0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/b33022c1_874cefc3 PS4, Line 998: ep_config_base, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/693057f1_182e6ea2 PS4, Line 998: ep_config_base, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/cd01d03c_ae2d8c46 PS4, Line 999: (1 << 24), ep_config_size); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/5a79c6cf_98e84954 PS4, Line 999: (1 << 24), ep_config_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/65b9fc6b_272b7f69 PS4, Line 999: (1 << 24), ep_config_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/0e31d39c_34260dd1 PS4, Line 1057: for (clk = PCIE_1_SLV_Q2A_AXI_CLK; clk < PCIE_CLK_COUNT - 3; clk ++) { space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/44b4eb0d_f78c4f1f PS4, Line 1064: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/db4eef96_13c9e648 PS4, Line 1092: if(ret) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/747e817e_7f84c799 PS4, Line 1126: if(!ret) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117963): https://review.coreboot.org/c/coreboot/+/52375/comment/569e80d6_a4ae0f74 PS4, Line 1126: if(!ret) { braces {} are not necessary for any arm of this statement