Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
mb/google/zork: Create Shuboz variant
Create the shuboz variant of the zork reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=b:none BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/shuboz/include/variant/ec.h A src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h A src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h A src/mainboard/google/zork/variants/shuboz/overridetree.cb A src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc A src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 13 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47152/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4f6bf7..41e4989 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -71,6 +71,7 @@ default "vilboz" if BOARD_GOOGLE_VILBOZ default "woomax" if BOARD_GOOGLE_WOOMAX default "dirinboz" if BOARD_GOOGLE_DIRINBOZ + default "shuboz" if BOARD_GOOGLE_SHUBOZ
config MAINBOARD_PART_NUMBER string @@ -82,6 +83,7 @@ default "Vilboz" if BOARD_GOOGLE_VILBOZ default "Woomax" if BOARD_GOOGLE_WOOMAX default "Dirinboz" if BOARD_GOOGLE_DIRINBOZ + default "Shuboz" if BOARD_GOOGLE_SHUBOZ
config DEVICETREE string diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 6f9a90c..8ed43f0 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -31,3 +31,7 @@ config BOARD_GOOGLE_DIRINBOZ bool "-> Dirinboz" select BOARD_GOOGLE_BASEBOARD_DALBOZ + +config BOARD_GOOGLE_SHUBOZ + bool "-> Shuboz" + select BOARD_GOOGLE_BASEBOARD_DALBOZ diff --git a/src/mainboard/google/zork/variants/shuboz/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/Makefile.inc new file mode 100644 index 0000000..295acd2 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./spd diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h b/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h b/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h b/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/shuboz/overridetree.cb b/src/mainboard/google/zork/variants/shuboz/overridetree.cb new file mode 100644 index 0000000..7645ba3 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/overridetree.cb @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "6000" #mw + register "fast_ppt_limit" = "9000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "2500" #second + register "sustained_power_limit" = "4800" #mw + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + }" + + # I2C3 for H1 + + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + end # device + +end # chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc new file mode 100644 index 0000000..3edeb96 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = ddr4-spd-empty.hex diff --git a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional)
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47152
to look at the new patch set (#2).
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
mb/google/zork: Create Shuboz variant
Create the shuboz variant of the zork reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=b:172021093 BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/shuboz/include/variant/ec.h A src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h A src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h A src/mainboard/google/zork/variants/shuboz/overridetree.cb A src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc A src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 13 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47152/2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
Patch Set 2: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v... PS2, Line 13: register "slow_ppt_limit" = "6000" #mw : register "fast_ppt_limit" = "9000" #mw : register "slow_ppt_time_constant" = "5" #second : register "stapm_time_constant" = "2500" #second : register "sustained_power_limit" = "4800" #mw quick heads-up: i submitted https://review.coreboot.org/c/coreboot/+/46840 into upstream today that changes those names. re-running create_coreboot_variant.sh after pulling the last changes should fix that issue
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Bhanu Prakash Maiya,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47152
to look at the new patch set (#3).
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
mb/google/zork: Create Shuboz variant
Create the shuboz variant of the zork reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=b:172021093 BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/shuboz/include/variant/ec.h A src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h A src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h A src/mainboard/google/zork/variants/shuboz/overridetree.cb A src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc A src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 13 files changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/47152/3
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/shuboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47152/2/src/mainboard/google/zork/v... PS2, Line 13: register "slow_ppt_limit" = "6000" #mw : register "fast_ppt_limit" = "9000" #mw : register "slow_ppt_time_constant" = "5" #second : register "stapm_time_constant" = "2500" #second : register "sustained_power_limit" = "4800" #mw
quick heads-up: i submitted https://review.coreboot. […]
Done
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
Patch Set 3: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
Patch Set 3: Code-Review+2
looks good to me.
FYI: In upstream coreboot review it's rather uncommon to +1 own patches; usually when a patch is uploaded for review and it's not marked as work in progress, not for merge or something like that, people will assume that it's working and ready to be reviewed. You probably can't +2 patches yet, but +2ing own patches is something that people shouldn't do as it basically would bypass the review. Having someone else do the review really helps spotting bugs. No need to worry about this here, since it's only a +1, but it would be good to keep this in mind for future patches
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47152 )
Change subject: mb/google/zork: Create Shuboz variant ......................................................................
mb/google/zork: Create Shuboz variant
Create the shuboz variant of the zork reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=b:172021093 BRANCH=none TEST=emerge-zork coreboot
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I3f62625f8cbde1c9adf8ab335edeb9e811e32679 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47152 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/shuboz/Makefile.inc A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/shuboz/include/variant/ec.h A src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h A src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h A src/mainboard/google/zork/variants/shuboz/overridetree.cb A src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc A src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt A src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt 13 files changed, 84 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index eb9092a..02181fb 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -71,6 +71,7 @@ default "vilboz" if BOARD_GOOGLE_VILBOZ default "woomax" if BOARD_GOOGLE_WOOMAX default "dirinboz" if BOARD_GOOGLE_DIRINBOZ + default "shuboz" if BOARD_GOOGLE_SHUBOZ
config MAINBOARD_PART_NUMBER string @@ -82,6 +83,7 @@ default "Vilboz" if BOARD_GOOGLE_VILBOZ default "Woomax" if BOARD_GOOGLE_WOOMAX default "Dirinboz" if BOARD_GOOGLE_DIRINBOZ + default "Shuboz" if BOARD_GOOGLE_SHUBOZ
config DEVICETREE string diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 6f9a90c..8ed43f0 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -31,3 +31,7 @@ config BOARD_GOOGLE_DIRINBOZ bool "-> Dirinboz" select BOARD_GOOGLE_BASEBOARD_DALBOZ + +config BOARD_GOOGLE_SHUBOZ + bool "-> Shuboz" + select BOARD_GOOGLE_BASEBOARD_DALBOZ diff --git a/src/mainboard/google/zork/variants/shuboz/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/Makefile.inc new file mode 100644 index 0000000..295acd2 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./spd diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h b/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h b/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h b/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/shuboz/overridetree.cb b/src/mainboard/google/zork/variants/shuboz/overridetree.cb new file mode 100644 index 0000000..1cc2364 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/overridetree.cb @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit_mW" = "6000" + register "fast_ppt_limit_mW" = "9000" + register "slow_ppt_time_constant_s" = "5" + register "stapm_time_constant_s" = "2500" + register "sustained_power_limit_mW" = "4800" + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + }" + + # I2C3 for H1 + + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + end # device + +end # chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc new file mode 100644 index 0000000..3edeb96 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = ddr4-spd-empty.hex diff --git a/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional)
-
Felix Held (Code Review) -
Kane Chen (Code Review)
-
Patrick Georgi (Code Review)