Change in ...coreboot[master]: mb/google/poppy/variants/nami: Use Pantheon VBT

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

John Su (Code Review)

5 Mar 2019 5 Mar '19

11:53 a.m.

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31747

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

mb/google/poppy/variants/nami: Use Pantheon VBT

Add new Pantheon sku-id for loading vbt-pantheon.bin

BUG=b:78663963 BRANCH=firmware-nami-10775.B TEST=Boots to OS and display comes up.

Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/31747/1

diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 8592cae..e279693 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -195,6 +195,8 @@ case SKU_0_PANTHEON: case SKU_1_PANTHEON: case SKU_2_PANTHEON: + case SKU_3_PANTHEON: + case SKU_4_PANTHEON: return "vbt-pantheon.bin"; case SKU_0_VAYNE: case SKU_1_VAYNE:

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

5 Mar 5 Mar

12:01 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 05 Mar 2019 03:01:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:03 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31747/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31747/1//COMMIT_MSG@13 PS1, Line 13: TEST=Boots to OS and display comes up. Before it didn’t come up?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 Mar 2019 12:03:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Su (Code Review)

6 Mar 6 Mar

3:34 p.m.

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31747/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31747/1//COMMIT_MSG@13 PS1, Line 13: TEST=Boots to OS and display comes up.

...

Before it didn’t come up?

No, it can come up. The vbt.bin change pwm delay setting. So I check display is ok or not. Thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Mar 2019 06:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

4:18 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

Patch Set 1:

Please add the VBT as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Wed, 06 Mar 2019 07:18:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Mar 7 Mar

5:03 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

Patch Set 1:

second the motion to add the vbt to the repo.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Comment-Date: Wed, 06 Mar 2019 20:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:03 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31747 )

Change subject: mb/google/poppy/variants/nami: Use Pantheon VBT ......................................................................

mb/google/poppy/variants/nami: Use Pantheon VBT

Add new Pantheon sku-id for loading vbt-pantheon.bin

BUG=b:78663963 BRANCH=firmware-nami-10775.B TEST=Boots to OS and display comes up.

Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31747 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/31747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd56905e1e04de6f307393ae23f741b93ff23a4c Gerrit-Change-Number: 31747 Gerrit-PatchSet: 2 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Frank Wu frank_wu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-MessageType: merged

2041

days inactive

2042

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
John Su (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)