Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal.
Uday Bhat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 )
Change subject: mb/google/rex: Enable audio BT offload
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/72881/comment/7c7cc2a9_40605426
PS4, Line 370: PAD_CFG_NF(GPP_VGPIO30, NONE, DEEP, NF3), /* BT_I2S_BCLK */
: PAD_CFG_NF(GPP_VGPIO31, NONE, DEEP, NF3), /* BT_I2S_SYNC */
: PAD_CFG_NF(GPP_VGPIO32, NONE, DEEP, NF3), /* BT_I2S_SDO */
: PAD_CFG_NF(GPP_VGPIO33, NONE, DEEP, NF3), /* BT_I2S_SDI */
These values should be NF2 as I2S1 needs to be used for BT offload […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c
Gerrit-Change-Number: 72881
Gerrit-PatchSet: 6
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Uday Bhat
uday.m.bhat@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Uday M Bhat
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 03:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Uday Bhat
uday.m.bhat@intel.com
Gerrit-MessageType: comment