Attention is currently required from: Raul Rangel, Martin Roth, Paul Menzel, Karthik Ramasubramanian, EricR Lai, Felix Held. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50450 )
Change subject: mb/google/guybrush: Second pass GPIO configuration ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50450/comment/4aada844_0c092e07 PS2, Line 7: mb/google/guybrush: Second pass GPIO configuration
Please make it a statement by adding a verb in imperative mood.
Done
https://review.coreboot.org/c/coreboot/+/50450/comment/3ebc6975_6b59bf77 PS2, Line 9: guybrush reference : schematic
Does it have a version?
Done
Patchset:
PS2:
I found the gpio table is out of data. It's better to check with schematic. […]
Just did another pass with the 0210 schematic.
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/50450/comment/36f3f057_fe8611e1 PS1, Line 19: PAD_WAKE(GPIO_4, PULL_NONE, EDGE_HIGH, S0i3),
We might need a debounce configuration too.
Ack, I will keep that in mind
https://review.coreboot.org/c/coreboot/+/50450/comment/4babdb49_c86ce2bc PS1, Line 22: /* EN_PP3300_WLAN */ : PAD_GPO(GPIO_6, LOW), : /* EN_PP3300_TCHPAD */ : PAD_GPO(GPIO_7, LOW),
Are we planning to enable these standard components in a subsequent CL or are these enable signals a […]
I intended to configure all of the gpios in low power state here and enable them as needed.
-
Mathew King (Code Review)