Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42582 )
Change subject: arch/x86/Makefile.inc: Drop unused reset.c rule ......................................................................
arch/x86/Makefile.inc: Drop unused reset.c rule
No x86 mainboard has a reset.c file.
Change-Id: I167629c7addf485944926d57cf0228606c0f32e5 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/42582/1
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 6297384..f0d7b03 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -288,9 +288,6 @@ ifeq ($(CONFIG_GENERATE_PIRQ_TABLE),y) ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/irq_tables.c endif -ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/reset.c),) -ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/reset.c -endif
ramstage-libs ?=
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42582 )
Change subject: arch/x86/Makefile.inc: Drop unused reset.c rule ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42582 )
Change subject: arch/x86/Makefile.inc: Drop unused reset.c rule ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42582 )
Change subject: arch/x86/Makefile.inc: Drop unused reset.c rule ......................................................................
arch/x86/Makefile.inc: Drop unused reset.c rule
No x86 mainboard has a reset.c file.
Change-Id: I167629c7addf485944926d57cf0228606c0f32e5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42582 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/Makefile.inc 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 1a1aa40..b5352e7 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -288,9 +288,6 @@ ifeq ($(CONFIG_GENERATE_PIRQ_TABLE),y) ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/irq_tables.c endif -ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/reset.c),) -ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/reset.c -endif
ramstage-libs ?=
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42582 )
Change subject: arch/x86/Makefile.inc: Drop unused reset.c rule ......................................................................
Patch Set 3: Code-Review+2