Change in coreboot[master]: mb/google/dedede: Enable trackpad support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Varshit B Pandya (Code Review)

3 Mar 2020 3 Mar '20

6:17 p.m.

Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 --- M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 51 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index f4fcd8d..2b93159 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -55,7 +55,7 @@ /* B2 : PROCHOT_ODL */ PAD_NC(GPP_B2, NONE), /* B3 : TRACKPAD_INT_ODL */ - PAD_NC(GPP_B3, NONE), + PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT), /* B4 : H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), /* B5 : PCIE_CLKREQ0_N */ diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 1a61143..9694d1a 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -1,5 +1,55 @@ chip soc/intel/tigerlake + device domain 0 on end + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 66, + .fall_time_ns = 90, + .data_hold_time_ns = 350, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + }, + }" device domain 0 on + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end #I2C 0 device pci 1c.7 on chip drivers/intel/wifi register "wake" = "GPE0_DW2_03"

Attachments:

attachment.htm (text/html — 7.4 KB)

Show replies by date

Varshit B Pandya (Code Review)

3 Mar 3 Mar

6:21 p.m.

Varshit B Pandya has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/2

Karthik Ramasubramanian (Code Review)

4 Mar 4 Mar

4:46 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 2:

LGTM. But please rebase on top of https://review.coreboot.org/c/coreboot/+/39114 so that it does not have to wait for other CLs to be merged.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-Comment-Date: Wed, 04 Mar 2020 03:46:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:48 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350 Can you please confirm with these configuration the measured speed was <= I2C_SPEED_FAST(400 KHz)

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-Comment-Date: Wed, 04 Mar 2020 03:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

3:13 p.m.

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350

...

Can you please confirm with these configuration the measured speed was <= I2C_SPEED_FAST(400 KHz)

Hello Karthik, Will measure and keep you posted

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 2 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 04 Mar 2020 14:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

4:37 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39236

to look at the new patch set (#3).

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST=Verify Trackpad cursor and click working fine

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/3

Varshit B Pandya (Code Review)

6:29 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39236

to look at the new patch set (#4).

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST=Verify Trackpad cursor and click working fine

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/4

Furquan Shaikh (Code Review)

6:31 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC We would want to also enable wake on trackpad line.

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: EDGE_SINGLE Why EDGE_SINGLE? At pad, we just configure the trigger to be level to pass the signal as is to APIC.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 04 Mar 2020 17:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Varshit B Pandya (Code Review)

5 Mar 5 Mar

5:41 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39236

to look at the new patch set (#5).

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST=Verify Trackpad cursor and click working fine

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/5

Karthik Ramasubramanian (Code Review)

8 Mar 8 Mar

6:21 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 6:

Also please rebase on top of https://review.coreboot.org/c/coreboot/+/39114. We have fixed the bootup issue with the GPIO pad config.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 6 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aamir Bohra aamir.bohra@intel.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 08 Mar 2020 05:21:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aamir Bohra (Code Review)

9 Mar 9 Mar

2:55 p.m.

Aamir Bohra has uploaded a new patch set (#7) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/7

Varshit B Pandya (Code Review)

11 Mar 11 Mar

12:19 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39236

to look at the new patch set (#8).

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/8

Aamir Bohra (Code Review)

2:27 p.m.

Aamir Bohra has uploaded a new patch set (#9) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/9

Aamir Bohra (Code Review)

2:32 p.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: EDGE_SINGLE

...

Why EDGE_SINGLE? At pad, we just configure the trigger to be level to pass the signal as is to APIC.

Done

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC

...

We would want to also enable wake on trackpad line.

I see GPE STS set in PMC reg corresponding to B3(GPE_DW0_03), should trigger wake.

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350

...

Hello Karthik, […]

Hi Karthik,

yes, the mean is around 350Khz

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 9 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 13:32:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit B Pandya varshit.b.pandya@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:49 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 9:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG@12 PS9, Line 12: Add TEST information. Please include that with the I2C rise/fall/hold time configuration, I2C clock frequency was measured to be 350 KHz.

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC

...

I see GPE STS set in PMC reg corresponding to B3(GPE_DW0_03), should trigger wake.

So no need to dual route the IRQ to SCI and IOAPIC?

I see that it is done that way in Hatch and it has the concerned GPIO group(GPP_A21) routed to GPE_DW0.

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350

...

Hi Karthik, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 9 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 15:49:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit B Pandya varshit.b.pandya@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Aamir Bohra (Code Review)

6:30 p.m.

Aamir Bohra has uploaded a new patch set (#10) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST: 1. Verify trackpad working 2. Verify I2C SCL frequency below 400Khz on trackpad operation

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/10

Aamir Bohra (Code Review)

6:35 p.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG@12 PS9, Line 12:

...

Add TEST information. […]

Done

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC

...

So no need to dual route the IRQ to SCI and IOAPIC? […]

changed for dual route

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 10 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 17:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

6:59 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 10: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@13 PS10, Line 13: TEST: Nit: Use the usual approach like "TEST=Verify trackpad functionality. Verify I2C SCL frequency is <= 400 KHz on trackpad operation."

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@17 PS10, Line 17: Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Nit: Move this line after Change-Id line.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 10 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Mar 2020 17:59:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aamir Bohra (Code Review)

12 Mar 12 Mar

5:52 a.m.

Aamir Bohra has uploaded a new patch set (#11) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST= Verify trackpad working. Verify I2C SCL frequency below 400Khz on trackpad operation.

Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com --- M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 52 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/39236/11

Aamir Bohra (Code Review)

5:53 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@13 PS10, Line 13: TEST:

...

Nit: Use the usual approach like "TEST=Verify trackpad functionality. […]

Done

https://review.coreboot.org/c/coreboot/+/39236/10//COMMIT_MSG@17 PS10, Line 17: Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com

...

Nit: Move this line after Change-Id line.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 11 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Mar 2020 04:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Aamir Bohra (Code Review)

5:53 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC

...

changed for dual route

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 11 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Mar 2020 04:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:41 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

mb/google/dedede: Enable trackpad support

1. Configure trackpad interrupt GPIO. 2. Set i2c0 configuration. 3. Add trackpad ACPI support.

TEST= Verify trackpad working. Verify I2C SCL frequency below 400Khz on trackpad operation.

Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39236 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 2 files changed, 52 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index af95f6a..fe903bd 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -55,7 +55,7 @@ /* B2 : PROCHOT_ODL */ PAD_NC(GPP_B2, NONE), /* B3 : TRACKPAD_INT_ODL */ - PAD_NC(GPP_B3, NONE), + PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, PLTRST, LEVEL, INVERT), /* B4 : H1_PCH_INT_ODL */ PAD_CFG_GPI_APIC(GPP_B4, NONE, PLTRST, LEVEL, INVERT), /* B5 : PCIE_CLKREQ0_N */ diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index ac9d576..061a0f8 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -1,3 +1,53 @@ chip soc/intel/tigerlake - device domain 0 on end + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 66, + .fall_time_ns = 90, + .data_hold_time_ns = 350, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + }, + }" + device domain 0 on + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end #I2C 0 + end end

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 12 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

9:04 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )

Change subject: mb/google/dedede: Enable trackpad support ......................................................................

Patch Set 12:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1322 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1321 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1320

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52c578aef591f5be90fb709bab4c8342ea9729e6 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 12 Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Mar 2020 08:04:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1717

days inactive

1726

days old

coreboot-gerrit@coreboot.org

22 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Aamir Bohra (Code Review)
Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Varshit B Pandya (Code Review)