Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52748 )
Change subject: soc/amd/picasso/dmi.c: Fix builds for boards without Google EC ......................................................................
soc/amd/picasso/dmi.c: Fix builds for boards without Google EC
For CRBs without Google EC with CONFIG_CHROMEOS=y we will get a build error as google_chromeec_cbi_get_dram_part_num() is not defined. Use EC_GOOGLE_CHROMEEC instead of CHROMEOS to gate the call.
BUG=b:184124605
Change-Id: I2b200f4fb11513c6fc17a2f0af3e12e5a3e3e5a1 Signed-off-by: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52748 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/dmi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/picasso/dmi.c b/src/soc/amd/picasso/dmi.c index 1133670..69928ad 100644 --- a/src/soc/amd/picasso/dmi.c +++ b/src/soc/amd/picasso/dmi.c @@ -158,7 +158,7 @@ } printk(BIOS_DEBUG, "AMD_FSP_DMI_HOB found\n");
- if (CONFIG(CHROMEOS)) { + if (CONFIG(EC_GOOGLE_CHROMEEC)) { /* Prefer DRAM part number from CBI. */ if (google_chromeec_cbi_get_dram_part_num( cbi_part_number, sizeof(cbi_part_number)) == 0) {