Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/23661 )
Change subject: chromeec: Fix ACPI compile warning
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23661/1/src/ec/google/chromeec/acpi/battery....
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/#/c/23661/1/src/ec/google/chromeec/acpi/battery....
PS1, Line 52: }
#ifdef ... […]
Right, or just use my snippet above and keep the Return (Zero) outside of both #if branches ,-))
--
To view, visit
https://review.coreboot.org/23661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae12c5d1aa749948ef4025c8b5e60c97e1b747a5
Gerrit-Change-Number: 23661
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Feb 2018 01:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No