Mengqi Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32462
Change subject: google/kukui: Modify SPI speed and tick_dly ......................................................................
google/kukui: Modify SPI speed and tick_dly
To support high-speed boot process, speed up spi and set suitable tick_dly
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/1
diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index 1efbc7a..232e17b 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -20,6 +20,6 @@ { mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 6 * MHz, 0); - mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 26 * MHz, - 0); + mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 56 * MHz, + 2); }
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Modify SPI speed and tick_dly ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@7 PS1, Line 7: Modify SPI speed and tick_dly Increase SPI flash speed to boot faster.
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@9 PS1, Line 9: To support high-speed boot process, speed up spi and set suitable tick_dl Increase SPI flash speed from 26MHz to 56MHZ and set correct tick_dly to get faster boot process.
Hello You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32462
to look at the new patch set (#2).
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
google/kukui: Increase SPI flash speed to boot faster.
Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/2
Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@7 PS1, Line 7: Modify SPI speed and tick_dly
Increase SPI flash speed to boot faster.
Done
https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@9 PS1, Line 9: To support high-speed boot process, speed up spi and set suitable tick_dl
Increase SPI flash speed from 26MHz to 56MHZ and set […]
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
Patch Set 2: Code-Review+1
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
Patch Set 2:
LGTM if you think you can drive this, but 56MHz is very fast (faster than any other Arm board I've seen to date). Please make sure you know that this is safe and have scoped the waveform to verify there's enough tolerance left.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@7 PS2, Line 7: google/kukui: Increase SPI flash speed to boot faster. Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@11 PS2, Line 11: 1. Please add hard numbers how much faster it now boots. 2. Why 56 MHz and not higher?
Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32462
to look at the new patch set (#3).
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
google/kukui: Increase SPI flash speed to boot faster
Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... File src/mainboard/google/kukui/bootblock.c:
https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... PS3, Line 27: 10); code indent should use tabs where possible
https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... PS3, Line 27: 10); please, no spaces at the start of a line
Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32462
to look at the new patch set (#4).
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
google/kukui: Increase SPI flash speed to boot faster
Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/4
Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32462
to look at the new patch set (#5).
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
google/kukui: Increase SPI flash speed to boot faster
Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/5
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32462 )
Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................
google/kukui: Increase SPI flash speed to boot faster
Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.
BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot
Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32462 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index ebd1e18..61f30af 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -21,8 +21,8 @@ { mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 6 * MHz, 0); - mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 26 * MHz, - 0); + mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 56 * MHz, + 2); gpio_set_spi_driving(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 10);
-
build bot (Jenkins) (Code Review) -
Hung-Te Lin (Code Review)
-
Julius Werner (Code Review)
-
Mengqi Zhang (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)