Change in ...coreboot[master]: google/kukui: Modify SPI speed and tick_dly

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Mengqi Zhang (Code Review)

26 Apr 2019 26 Apr '19

8:57 a.m.

Mengqi Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32462

Change subject: google/kukui: Modify SPI speed and tick_dly ......................................................................

google/kukui: Modify SPI speed and tick_dly

To support high-speed boot process, speed up spi and set suitable tick_dly

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/1

diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index 1efbc7a..232e17b 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -20,6 +20,6 @@ { mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 6 * MHz, 0); - mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 26 * MHz, - 0); + mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 56 * MHz, + 2); }

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Hung-Te Lin (Code Review)

26 Apr 26 Apr

9:40 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Modify SPI speed and tick_dly ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@7 PS1, Line 7: Modify SPI speed and tick_dly Increase SPI flash speed to boot faster.

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@9 PS1, Line 9: To support high-speed boot process, speed up spi and set suitable tick_dl Increase SPI flash speed from 26MHz to 56MHZ and set correct tick_dly to get faster boot process.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 1 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Apr 2019 07:40:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mengqi Zhang (Code Review)

10:48 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Hello You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32462

to look at the new patch set (#2).

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

google/kukui: Increase SPI flash speed to boot faster.

Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Mengqi Zhang (Code Review)

10:48 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@7 PS1, Line 7: Modify SPI speed and tick_dly

...

Increase SPI flash speed to boot faster.

Done

https://review.coreboot.org/#/c/32462/1//COMMIT_MSG@9 PS1, Line 9: To support high-speed boot process, speed up spi and set suitable tick_dl

...

Increase SPI flash speed from 26MHz to 56MHZ and set […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Apr 2019 08:48:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

11:05 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Apr 2019 09:05:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

27 Apr 27 Apr

12:50 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

Patch Set 2:

LGTM if you think you can drive this, but 56MHz is very fast (faster than any other Arm board I've seen to date). Please make sure you know that this is safe and have scoped the waveform to verify there's enough tolerance left.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Fri, 26 Apr 2019 22:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

12:50 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 26 Apr 2019 22:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

6 May 6 May

5:48 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster. ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/32462/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@7 PS2, Line 7: google/kukui: Increase SPI flash speed to boot faster. Please remove the dot/period at the end of the commit message summary.

https://review.coreboot.org/#/c/32462/2//COMMIT_MSG@11 PS2, Line 11: 1. Please add hard numbers how much faster it now boots. 2. Why 56 MHz and not higher?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 2 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 06 May 2019 15:48:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mengqi Zhang (Code Review)

7 May 7 May

4:07 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32462

to look at the new patch set (#3).

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

google/kukui: Increase SPI flash speed to boot faster

Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 5 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 3 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

4:07 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... File src/mainboard/google/kukui/bootblock.c:

https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... PS3, Line 27: 10); code indent should use tabs where possible

https://review.coreboot.org/#/c/32462/3/src/mainboard/google/kukui/bootblock... PS3, Line 27: 10); please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 3 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 07 May 2019 14:07:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mengqi Zhang (Code Review)

4:11 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32462

to look at the new patch set (#4).

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

google/kukui: Increase SPI flash speed to boot faster

Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 4 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mengqi Zhang (Code Review)

10 May 10 May

3:01 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Hello Julius Werner, You-Cheng Syu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32462

to look at the new patch set (#5).

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

google/kukui: Increase SPI flash speed to boot faster

Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/32462/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 5 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

10 Jun 10 Jun

1:53 p.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 6 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Jun 2019 11:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 Jun 21 Jun

10:39 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 6 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 21 Jun 2019 08:39:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:39 a.m.

New subject: Change in ...coreboot[master]: google/kukui: Increase SPI flash speed to boot faster

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32462 )

Change subject: google/kukui: Increase SPI flash speed to boot faster ......................................................................

google/kukui: Increase SPI flash speed to boot faster

Increase SPI flash speed from 26MHz to 56MHz and set correct tick_dly to get faster boot process.

BUG=b:80501386 BRANCH=none TEST=emerge-kukui coreboot; emerge-elm coreboot

Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Signed-off-by: Mengqi Zhang Mengqi.Zhang@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32462 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/bootblock.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index ebd1e18..61f30af 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -21,8 +21,8 @@ { mtk_spi_init(CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS, SPI_PAD0_MASK, 6 * MHz, 0); - mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 26 * MHz, - 0); + mtk_spi_init(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 56 * MHz, + 2); gpio_set_spi_driving(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, SPI_PAD0_MASK, 10);

-- To view, visit https://review.coreboot.org/c/coreboot/+/32462 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8f44883b4f4a198146330caf5420dc39d5592a0a Gerrit-Change-Number: 32462 Gerrit-PatchSet: 7 Gerrit-Owner: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Mengqi Zhang Mengqi.Zhang@mediatek.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1919

days inactive

1975

days old

coreboot-gerrit@coreboot.org

14 comments

6 participants

tags (0)

participants (6)

build bot (Jenkins) (Code Review)
Hung-Te Lin (Code Review)
Julius Werner (Code Review)
Mengqi Zhang (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)