Change in coreboot[master]: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and...

[Jason V Le (Code Review)]

Jason V Le has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for UP4
......................................................................

/mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
UP4

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/1

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index 928ae36..c2c6902 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -18,13 +18,13 @@

register "usb2_ports[0]" = "USB2_PORT_MID(OC3)"		# Type-C Port1
    register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)"	# M.2 WWAN
-	register "usb2_ports[2]" = "USB2_PORT_MID(OC0)"		# M.2 Bluetooth, USB3/2 Type A port1
-	register "usb2_ports[3]" = "USB2_PORT_MID(OC3)"		# USB3/2 Type A port1
+	register "usb2_ports[2]" = "USB2_PORT_MID(OC0)"		# M.2 Bluetooth, USB3/2 Type A Port1
+	register "usb2_ports[3]" = "USB2_PORT_MID(OC3)"		# USB3/2 Type A Port 1
    register "usb2_ports[4]" = "USB2_PORT_MID(OC3)"		# Type-C Port2
-	register "usb2_ports[5]" = "USB2_PORT_MID(OC3)"		# Type-C Port3
-	register "usb3_ports[6]" = "USB3_PORT_EMPTY"		# Not used
-	register "usb3_ports[7]" = "USB3_PORT_EMPTY"		# Not used
-	register "usb3_ports[8]" = "USB3_PORT_EMPTY"		# Not used
+	register "usb2_ports[5]" = "USB2_PORT_MID(OC3)"		# Type-C Port3 / MECC
+	register "usb2_ports[6]" = "USB2_PORT_EMPTY"		# Not used
+	register "usb2_ports[7]" = "USB2_PORT_EMPTY"		# Not used
+	register "usb2_ports[8]" = "USB2_PORT_EMPTY"		# Not used
    register "usb2_ports[9]" = "USB2_PORT_MID(OC3)"		# CNVi/BT

register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)"	# USB3/2 Type A port1
@@ -66,9 +66,16 @@
    # enabling EDP in PortA
    register "DdiPortAConfig" = "1"

+	register "DdiPortAHpd" = "1"
+	register "DdiPortADdc" = "0"
    register "DdiPortBHpd" = "1"
+	register "DdiPortBDdc" = "1"
+	register "DdiPortCHpd" = "0"
+	register "DdiPortCDdc" = "0"
    register "DdiPort1Hpd" = "1"
-	register "DdiPort1Ddc" = "1"
+	register "DdiPort1Ddc" = "0"
+	register "DdiPort2Hpd" = "1"
+	register "DdiPort2Ddc" = "0"

register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for UP4
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@7 
PS2, Line 7: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
Please follow the convention (`git log --oneline`):
> mb/intel/tglrvb/var/tglrvp_up4: Enable onboard HDMI and USB Type-C displays

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@14 
PS2, Line 14: type-C
USB Type-C

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@17 
PS2, Line 17: 
Missing Signed-off-by line. Run `make gitconfig`.

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Shreesh Chhabbi, Julius Werner, Bernardo Perez Priego,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45016

to look at the new patch set (#3).

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for UP4
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
UP4

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/3

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Shreesh Chhabbi, Julius Werner, Bernardo Perez Priego,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45016

to look at the new patch set (#4).

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for UP4
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
UP4

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/4

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Shreesh Chhabbi, Julius Werner, Bernardo Perez Priego,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45016

to look at the new patch set (#5).

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/5

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Anil Kumar K (Code Review)]

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Jason V Le has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 5:

(3 comments)

If you don't have any other concern or input, could you please approve the code change?

Thx,
Jason

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@7 
PS2, Line 7: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
> Please follow the convention (`git log --oneline`): […]

Ack

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@14 
PS2, Line 14: type-C
> USB Type-C

Ack

https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@17 
PS2, Line 17:
> Missing Signed-off-by line. Run `make gitconfig`.

Ack

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has uploaded a new patch set (#6) to the change originally created by Jason V Le. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

BUG=None
TEST= Tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and
USB Type-C connectors to make sure the displays get detected and enabled.

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/6

Change in coreboot[master]: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has uploaded a new patch set (#7) to the change originally created by Jason V Le. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

BUG=None
TEST=Tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and
USB Type-C connectors to make sure the displays get detected and enabled.

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/7

Change in coreboot[master]: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has uploaded a new patch set (#8) to the change originally created by Jason V Le. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp: Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

BUG=None
TEST=Tested hot-plug/unplug HDMI displays with onboard micro-hdmi
connector and USB Type-C connectors to make sure the displays get
detected and enabled.

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/8

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Furquan Shaikh, Shreesh Chhabbi, Tim Wawrzynczak, Julius Werner, Nick Vaccaro, Bernardo Perez Priego,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45016

to look at the new patch set (#9).

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/9

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 9: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG@13 
PS9, Line 13: Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled
Missing BUG: field.

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG@13 
PS9, Line 13: Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled
> Missing BUG: field.

This is for Intel's TGL RVP

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Hello build bot (Jenkins), Anil Kumar K, Cliff Huang, Furquan Shaikh, Shreesh Chhabbi, Tim Wawrzynczak, Julius Werner, Nick Vaccaro, Bernardo Perez Priego,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45016

to look at the new patch set (#10).

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

BUG: System not able to detect displays attached to onboard micro-HDMI or Type-C connectors
TEST: hot-plug/unplug HDMI displays with onboard micro-HDMI connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/45016/10

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Jason V Le (Code Review)]

Jason V Le has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 10:

Could you review and approve patchset 10?
Thx

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/9//COMMIT_MSG@13 
PS9, Line 13: Test: tested hot-plug/unplug HDMI displays with onboard micro-hdmi connector and USB Type-C connectors to make sure the displays get detected and enabled
> This is for Intel's TGL RVP

Ack

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP

- Enable DDC pins for DDI-B
- Enable HPD pins for DDI-1/DDI-2
- Update MPHY/USB2 Mapping to match with the TGL-Y RVP schematic

BUG: System not able to detect displays attached to onboard micro-HDMI or Type-C connectors
TEST: hot-plug/unplug HDMI displays with onboard micro-HDMI connector and USB Type-C connectors to make sure the displays get detected and enabled

Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Signed-off-by: Jason Le 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45016
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
1 file changed, 14 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index 3e2b342..842ae68 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -21,10 +21,13 @@

register "usb2_ports[0]" = "USB2_PORT_MID(OC3)"		# Type-C Port1
    register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)"	# M.2 WWAN
-	register "usb2_ports[2]" = "USB2_PORT_MID(OC0)"		# M.2 Bluetooth, USB3/2 Type A port1
-	register "usb2_ports[3]" = "USB2_PORT_MID(OC3)"		# USB3/2 Type A port1
+	register "usb2_ports[2]" = "USB2_PORT_MID(OC0)"		# M.2 Bluetooth, USB3/2 Type A Port1
+	register "usb2_ports[3]" = "USB2_PORT_MID(OC3)"		# USB3/2 Type A Port 1
    register "usb2_ports[4]" = "USB2_PORT_MID(OC3)"		# Type-C Port2
-	register "usb2_ports[5]" = "USB2_PORT_MID(OC3)"		# Type-C Port3
+	register "usb2_ports[5]" = "USB2_PORT_MID(OC3)"		# Type-C Port3 / MECC
+	register "usb2_ports[6]" = "USB2_PORT_EMPTY"		# Not used
+	register "usb2_ports[7]" = "USB2_PORT_EMPTY"		# Not used
+	register "usb2_ports[8]" = "USB2_PORT_EMPTY"		# Not used
    register "usb2_ports[9]" = "USB2_PORT_MID(OC3)"		# CNVi/BT

register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)"	# USB3/2 Type A port1
@@ -65,9 +68,16 @@
    # enabling EDP in PortA
    register "DdiPortAConfig" = "1"

+	register "DdiPortAHpd" = "1"
+	register "DdiPortADdc" = "0"
    register "DdiPortBHpd" = "1"
+	register "DdiPortBDdc" = "1"
+	register "DdiPortCHpd" = "0"
+	register "DdiPortCDdc" = "0"
    register "DdiPort1Hpd" = "1"
-	register "DdiPort1Ddc" = "1"
+	register "DdiPort1Ddc" = "0"
+	register "DdiPort2Hpd" = "1"
+	register "DdiPort2Ddc" = "0"

register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,

Change in coreboot[master]: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C ...

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )

Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45016/11//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45016/11//COMMIT_MSG@7 
PS11, Line 7: mb/intel/tglrvp/variants/tglrvp_up4 - Enable
Thank you for the commit, but please use a colon in the future. See `git log --oneline` what is common.