Jason V Le has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45016 )
Change subject: mb/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for TGL-Y RVP
......................................................................
Patch Set 5:
(3 comments)
If you don't have any other concern or input, could you please approve the code change?
Thx,
Jason
https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@7
PS2, Line 7: /mainboard/intel/tglrvp/variants/tglrvp_up4 - Enable onboard HDMI and type-C displays for
Please follow the convention (`git log --oneline`): […]
Ack
https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@14
PS2, Line 14: type-C
USB Type-C
Ack
https://review.coreboot.org/c/coreboot/+/45016/2//COMMIT_MSG@17
PS2, Line 17:
Missing Signed-off-by line. Run `make gitconfig`.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08a1b16a8fa45cf0f366661395b9f2aa25c44935
Gerrit-Change-Number: 45016
Gerrit-PatchSet: 5
Gerrit-Owner: Jason V Le
jason.v.le@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Wed, 16 Sep 2020 00:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment