Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee, Derek Huang, Brandon Breitenstein, Curtis Chen.
Curtis Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 )
Change subject: mb/google/volteer: Create APIs for USB-C DP alternate mode support
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/57139/comment/e3897858_9ad16c34
PS9, Line 296: WAIT_FOR_DISPLAYPORT_TIMEOUT
Does the waiting have to be done serially? can it be done in parallel?
Yes, we have a draft idea at my 8/26 comment.
The wait could be done in parallel.
Also, not sure google needs to support 2 output or not.
If yes,
in google_chromeec_pd_get_amode(uint16_t svid)
we could use "ret |= 1 << i" rather than return directly.
(Based on my 8/26 comment)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50
Gerrit-Change-Number: 57139
Gerrit-PatchSet: 9
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Curtis Chen
curtis.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 05:01:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment