Attention is currently required from: Marshall Dawson, Paul Menzel, Fred Reitberger, Rob Barnes, Julian Schroeder.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62349 )
Change subject: soc/amd/common/fsp/fsp_validate.c: print warning instead of error
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62349/comment/627118c9_a300a05e
PS2, Line 10: warning instead of an error.
Why? Is that for CI testing, or is it expected to have such FSP binaries?
The FSP spec, IIRC, doesn't require valid image revision info. The older AMD FSPs attempt to provide one but fail and instead put in '1'. I fixed that since but older FSP binaries will still be around for a while.
Patchset:
PS1:
No Signed-off-by line in commit message
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c5a387b81205fe93382778090260e41e261776
Gerrit-Change-Number: 62349
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Comment-Date: Tue, 01 Mar 2022 18:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment